From dc2e700057e395f0ede4bff156b474248e3eba95 Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Sat, 21 Feb 2015 21:37:08 +0100 Subject: [PATCH] PPP, CORE, using u8_t on ioctl command instead of int We don't need an int here, all commands are between 0 and 255. --- src/api/pppapi.c | 2 +- src/include/lwip/pppapi.h | 4 ++-- src/include/netif/ppp/ppp.h | 2 +- src/netif/ppp/ppp.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/api/pppapi.c b/src/api/pppapi.c index 759b3f1d..4f606a14 100644 --- a/src/api/pppapi.c +++ b/src/api/pppapi.c @@ -350,7 +350,7 @@ pppapi_do_ppp_ioctl(struct pppapi_msg_msg *msg) * tcpip_thread context. */ err_t -pppapi_ioctl(ppp_pcb *pcb, int cmd, void *arg) +pppapi_ioctl(ppp_pcb *pcb, u8_t cmd, void *arg) { struct pppapi_msg msg; msg.function = pppapi_do_ppp_ioctl; diff --git a/src/include/lwip/pppapi.h b/src/include/lwip/pppapi.h index dadbc689..cff1d101 100644 --- a/src/include/lwip/pppapi.h +++ b/src/include/lwip/pppapi.h @@ -93,7 +93,7 @@ struct pppapi_msg_msg { u16_t holdoff; } open; struct { - int cmd; + u8_t cmd; void *arg; } ioctl; #if LWIP_NETIF_STATUS_CALLBACK @@ -137,7 +137,7 @@ err_t pppapi_open(ppp_pcb *pcb, u16_t holdoff); err_t pppapi_close(ppp_pcb *pcb); void pppapi_sighup(ppp_pcb *pcb); err_t pppapi_free(ppp_pcb *pcb); -err_t pppapi_ioctl(ppp_pcb *pcb, int cmd, void *arg); +err_t pppapi_ioctl(ppp_pcb *pcb, u8_t cmd, void *arg); #if LWIP_NETIF_STATUS_CALLBACK void pppapi_set_netif_statuscallback(ppp_pcb *pcb, netif_status_callback_fn status_callback); #endif /* LWIP_NETIF_STATUS_CALLBACK */ diff --git a/src/include/netif/ppp/ppp.h b/src/include/netif/ppp/ppp.h index 3cd8c5ba..a0daca51 100644 --- a/src/include/netif/ppp/ppp.h +++ b/src/include/netif/ppp/ppp.h @@ -497,7 +497,7 @@ err_t ppp_free(ppp_pcb *pcb); * Get and set parameters for the given connection. * Return 0 on success, an error code on failure. */ -err_t ppp_ioctl(ppp_pcb *pcb, int cmd, void *arg); +err_t ppp_ioctl(ppp_pcb *pcb, u8_t cmd, void *arg); /* Get the PPP netif interface */ #define ppp_netif(ppp) (ppp->netif) diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index 894e81c5..ce989531 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -341,7 +341,7 @@ err_t ppp_free(ppp_pcb *pcb) { /* Get and set parameters for the given connection. * Return 0 on success, an error code on failure. */ err_t -ppp_ioctl(ppp_pcb *pcb, int cmd, void *arg) +ppp_ioctl(ppp_pcb *pcb, u8_t cmd, void *arg) { if (pcb == NULL) { return ERR_VAL;