mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-25 18:14:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

mdns: implement random time for initial probing

Browse Source
This commit is contained in:
Simon Goldschmidt 2018-06-28 22:10:45 +02:00
parent af2cbad64a
commit cc8995823a
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/apps/mdns/mdns.c
View File

@ -139,6 +139,12 @@ static mdns_name_result_cb_t mdns_name_result_cb;
#define MDNS_PROBE_DELAY_MS 250 #define MDNS_PROBE_DELAY_MS 250
#define MDNS_PROBE_COUNT 3 #define MDNS_PROBE_COUNT 3
#ifdef LWIP_RAND
/* first probe timeout SHOULD be random 0-250 ms*/
#define MDNS_INITIAL_PROBE_DELAY_MS (LWIP_RAND() % MDNS_PROBE_DELAY_MS)
#else
#define MDNS_INITIAL_PROBE_DELAY_MS MDNS_PROBE_DELAY_MS
#endif
#define MDNS_PROBING_NOT_STARTED 0 #define MDNS_PROBING_NOT_STARTED 0
#define MDNS_PROBING_ONGOING 1 #define MDNS_PROBING_ONGOING 1
@ -1562,7 +1568,7 @@ mdns_handle_question(struct mdns_packet *pkt)
if (mdns->probing_state != MDNS_PROBING_COMPLETE) { if (mdns->probing_state != MDNS_PROBING_COMPLETE) {
/* Don't answer questions until we've verified our domains via probing */ /* Don't answer questions until we've verified our domains via probing */
/* todo we should check incoming questions during probing for tiebreaking */ /* @todo we should check incoming questions during probing for tiebreaking */
return; return;
} }
@ -2327,7 +2333,7 @@ mdns_resp_announce(struct netif *netif)
mdns_announce(netif, IP4_ADDR_ANY); mdns_announce(netif, IP4_ADDR_ANY);
} }
#endif #endif
} /* else: ip address changed while probing was ongoing? todo reset counter to restart? */ } /* else: ip address changed while probing was ongoing? @todo reset counter to restart? */
} }
/** Register a callback function that is called if probing is completed successfully /** Register a callback function that is called if probing is completed successfully
@ -2359,11 +2365,10 @@ mdns_resp_restart(struct netif *netif)
if (mdns->probing_state == MDNS_PROBING_ONGOING) { if (mdns->probing_state == MDNS_PROBING_ONGOING) {
sys_untimeout(mdns_probe, netif); sys_untimeout(mdns_probe, netif);
} }
/*todo first probe timeout SHOULD be random 0-250 ms*/ /* @todo if we've failed 15 times within a 10 second period we MUST wait 5 seconds (or wait 5 seconds every time except first)*/
/*todo if we've failed 15 times within a 10 second period we MUST wait 5 seconds (or wait 5 seconds every time except first)*/
mdns->probes_sent = 0; mdns->probes_sent = 0;
mdns->probing_state = MDNS_PROBING_ONGOING; mdns->probing_state = MDNS_PROBING_ONGOING;
sys_timeout(MDNS_PROBE_DELAY_MS, mdns_probe, netif); sys_timeout(MDNS_INITIAL_PROBE_DELAY_MS, mdns_probe, netif);
} }
/** /**