From c8fda8d46c591118a9cf4b746b4f67ae002e43fe Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Thu, 9 Apr 2020 03:32:05 +0200 Subject: [PATCH] PPP: use netif_set_up() instead of setting NETIF_FLAG_UP flag NETIF_FLAG_UP flag is not supposed to be set by netif init callback anymore, call netif_set_up() instead. Sure it would be better to let user application code call netif_set_up() by itself as it is now meant to be but let's not break compatibility for now and add a FIXME for next release with allowed behavior break. Signed-off-by: Sylvain Rochet --- src/netif/ppp/ppp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index b847609c..6b426130 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -473,7 +473,6 @@ static err_t ppp_netif_init_cb(struct netif *netif) { #if PPP_IPV6_SUPPORT netif->output_ip6 = ppp_netif_output_ip6; #endif /* PPP_IPV6_SUPPORT */ - netif->flags = NETIF_FLAG_UP; #if LWIP_NETIF_HOSTNAME /* @todo: Initialize interface hostname */ /* netif_set_hostname(netif, "lwip"); */ @@ -707,6 +706,7 @@ ppp_pcb *ppp_new(struct netif *pppif, const struct link_callbacks *callbacks, vo PPPDEBUG(LOG_ERR, ("ppp_new: netif_add failed\n")); return NULL; } + netif_set_up(pcb->netif); pcb->link_cb = callbacks; pcb->link_ctx_cb = link_ctx_cb;