mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-11-18 20:10:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

tcp: Check tcp_output return values in tests

Browse Source 
Found with clang-analyzer
This commit is contained in:
Erik Ekman 2021-01-19 20:14:32 +01:00
parent 21fba21054
commit c825eb3604
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/unit/tcp/test_tcp.c
View File

@ -665,6 +665,7 @@ START_TEST(test_tcp_fast_rexmit_wraparound)
check_seqnos(pcb->unsent, 6, seqnos); check_seqnos(pcb->unsent, 6, seqnos);
EXPECT(pcb->unacked == NULL); EXPECT(pcb->unacked == NULL);
err = tcp_output(pcb); err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT(txcounters.num_tx_calls == 2); EXPECT(txcounters.num_tx_calls == 2);
EXPECT(txcounters.num_tx_bytes == 2 * (TCP_MSS + 40U)); EXPECT(txcounters.num_tx_bytes == 2 * (TCP_MSS + 40U));
memset(&txcounters, 0, sizeof(txcounters)); memset(&txcounters, 0, sizeof(txcounters));
@ -753,6 +754,7 @@ START_TEST(test_tcp_rto_rexmit_wraparound)
check_seqnos(pcb->unsent, 6, seqnos); check_seqnos(pcb->unsent, 6, seqnos);
EXPECT(pcb->unacked == NULL); EXPECT(pcb->unacked == NULL);
err = tcp_output(pcb); err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT(txcounters.num_tx_calls == 2); EXPECT(txcounters.num_tx_calls == 2);
EXPECT(txcounters.num_tx_bytes == 2 * (TCP_MSS + 40U)); EXPECT(txcounters.num_tx_bytes == 2 * (TCP_MSS + 40U));
memset(&txcounters, 0, sizeof(txcounters)); memset(&txcounters, 0, sizeof(txcounters));
@ -1101,6 +1103,7 @@ START_TEST(test_tcp_rto_tracking)
check_seqnos(pcb->unsent, 5, seqnos); check_seqnos(pcb->unsent, 5, seqnos);
EXPECT(pcb->unacked == NULL); EXPECT(pcb->unacked == NULL);
err = tcp_output(pcb); err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT(txcounters.num_tx_calls == 5); EXPECT(txcounters.num_tx_calls == 5);
EXPECT(txcounters.num_tx_bytes == 5 * (TCP_MSS + 40U)); EXPECT(txcounters.num_tx_bytes == 5 * (TCP_MSS + 40U));
memset(&txcounters, 0, sizeof(txcounters)); memset(&txcounters, 0, sizeof(txcounters));
@ -1216,6 +1219,7 @@ static void test_tcp_rto_timeout_impl(int link_down)
err = tcp_write(pcb, &tx_data[0], TCP_MSS, TCP_WRITE_FLAG_COPY); err = tcp_write(pcb, &tx_data[0], TCP_MSS, TCP_WRITE_FLAG_COPY);
EXPECT_RET(err == ERR_OK); EXPECT_RET(err == ERR_OK);
err = tcp_output(pcb); err = tcp_output(pcb);
EXPECT_RET(err == ERR_OK);
EXPECT(txcounters.num_tx_calls == 1); EXPECT(txcounters.num_tx_calls == 1);
EXPECT(txcounters.num_tx_bytes == 1 * (TCP_MSS + 40U)); EXPECT(txcounters.num_tx_bytes == 1 * (TCP_MSS + 40U));
memset(&txcounters, 0, sizeof(txcounters)); memset(&txcounters, 0, sizeof(txcounters));