mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-26 12:13:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

mDNS: authority section of probe message needs to contain all records

Browse Source 
see RFC 6762 section 8.2: for tiebreaking to work correctly in all
cases, the Authority section must contain all the records and
proposed rdata being probed for uniqueness.
This commit is contained in:
Jasper Verschueren 2018-10-10 09:59:02 +02:00 committed by Dirk Ziegelmeier
parent 3043d9d023
commit c4321330d0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/apps/mdns/mdns.c
View File

@ -917,13 +917,14 @@ mdns_send_probe(struct netif* netif, const ip_addr_t *destination)
/* Add answers to the questions above into the authority section for tiebreaking */ /* Add answers to the questions above into the authority section for tiebreaking */
#if LWIP_IPV4 #if LWIP_IPV4
if (!ip4_addr_isany_val(*netif_ip4_addr(netif))) { if (!ip4_addr_isany_val(*netif_ip4_addr(netif))) {
pkt.host_replies = REPLY_HOST_A; outmsg.host_replies = REPLY_HOST_A | REPLY_HOST_PTR_V4;
} }
#endif #endif
#if LWIP_IPV6 #if LWIP_IPV6
for (i = 0; i < LWIP_IPV6_NUM_ADDRESSES; i++) { for (i = 0; i < LWIP_IPV6_NUM_ADDRESSES; i++) {
if (ip6_addr_isvalid(netif_ip6_addr_state(netif, i))) { if (ip6_addr_isvalid(netif_ip6_addr_state(netif, i))) {
pkt.host_replies |= REPLY_HOST_AAAA; outmsg.host_replies |= REPLY_HOST_AAAA | REPLY_HOST_PTR_V6;
outmsg.host_reverse_v6_replies |= (1 << i);
} }
} }
#endif #endif
@ -931,7 +932,8 @@ mdns_send_probe(struct netif* netif, const ip_addr_t *destination)
for (i = 0; i < MDNS_MAX_SERVICES; i++) { for (i = 0; i < MDNS_MAX_SERVICES; i++) {
struct mdns_service *serv = mdns->services[i]; struct mdns_service *serv = mdns->services[i];
if (serv) { if (serv) {
pkt.serv_replies[i] = REPLY_SERVICE_SRV | REPLY_SERVICE_TXT; outmsg.serv_replies[i] = REPLY_SERVICE_SRV | REPLY_SERVICE_TXT
| REPLY_SERVICE_TYPE_PTR | REPLY_SERVICE_NAME_PTR;
} }
} }