mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-25 18:14:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix double-free when closing mbedTLS connections

Browse Source 
Partly revert commit 0486100a2b from 07.08.2017 as it breaks layering: every layer must free its own altcp_pcb. Freeing the inner_conn is not the right way.
This commit is contained in:
goldsimon 2017-11-14 22:21:08 +01:00
parent 6ef5f68c72
commit bd2e820829
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/apps/altcp_tls/altcp_tls_mbedtls.c
View File

@ -563,6 +563,8 @@ altcp_mbedtls_setup(void *conf, struct altcp_pcb *conn, struct altcp_pcb *inner_
if (!conf) { if (!conf) {
return ERR_ARG; return ERR_ARG;
} }
LWIP_ASSERT("invalid inner_conn", conn != inner_conn);
/* allocate mbedtls context */ /* allocate mbedtls context */
state = altcp_mbedtls_alloc(conf); state = altcp_mbedtls_alloc(conf);
if (state == NULL) { if (state == NULL) {
@ -970,10 +972,6 @@ altcp_mbedtls_dealloc(struct altcp_pcb *conn)
altcp_mbedtls_free(state->conf, state); altcp_mbedtls_free(state->conf, state);
conn->state = NULL; conn->state = NULL;
} }
if (conn->inner_conn) {
altcp_free(conn->inner_conn);
conn->inner_conn = NULL;
}
} }
} }