mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-01-29 00:32:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

PPP, PPPoS, moved advise about modem from pppos_create() to ppp_open()

Browse Source 
pppos_create() can be called whether the modem is ready to process the
PPP session since pppos_create() does not start the PPP session anymore,
moved the advise from pppos_create() to ppp_open().
This commit is contained in:
Sylvain Rochet 2015-02-22 16:20:03 +01:00
parent 1e82003bf9
commit b0b7240022
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/include/netif/ppp/ppp.h
View File

@ -460,6 +460,9 @@ void ppp_set_notify_phase_callback(ppp_pcb *pcb, ppp_notify_phase_cb_fn notify_p
* *
* Holdoff is the time to wait (in seconds) before initiating * Holdoff is the time to wait (in seconds) before initiating
* the connection. * the connection.
*
* If this port connects to a modem, the modem connection must be
* established before calling this.
*/ */
err_t ppp_open(ppp_pcb *pcb, u16_t holdoff); err_t ppp_open(ppp_pcb *pcb, u16_t holdoff);

3
src/netif/ppp/ppp.c
View File

@ -255,6 +255,9 @@ void ppp_set_notify_phase_callback(ppp_pcb *pcb, ppp_notify_phase_cb_fn notify_p
* *
* Holdoff is the time to wait (in seconds) before initiating * Holdoff is the time to wait (in seconds) before initiating
* the connection. * the connection.
*
* If this port connects to a modem, the modem connection must be
* established before calling this.
*/ */
err_t ppp_open(ppp_pcb *pcb, u16_t holdoff) { err_t ppp_open(ppp_pcb *pcb, u16_t holdoff) {
if (pcb->phase != PPP_PHASE_DEAD) { if (pcb->phase != PPP_PHASE_DEAD) {

3
src/netif/ppp/pppos.c
View File

@ -167,9 +167,6 @@ ppp_get_fcs(u8_t byte)
/* /*
* Create a new PPP connection using the given serial I/O device. * Create a new PPP connection using the given serial I/O device.
* *
* If this port connects to a modem, the modem connection must be
* established before calling this.
*
* Return 0 on success, an error code on failure. * Return 0 on success, an error code on failure.
*/ */
ppp_pcb *pppos_create(struct netif *pppif, sio_fd_t fd, ppp_pcb *pppos_create(struct netif *pppif, sio_fd_t fd,