From a2915b714214a234cd76f3e75d1485210a833c7d Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Sat, 7 Jan 2017 22:13:12 +0800 Subject: [PATCH] mqtt: Slightly improve mqtt_create_request Mainly for better readability, also save NULL test while iterating the for loop. Signed-off-by: Axel Lin --- src/apps/mqtt/mqtt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/apps/mqtt/mqtt.c b/src/apps/mqtt/mqtt.c index 351b6752..a8588a1a 100644 --- a/src/apps/mqtt/mqtt.c +++ b/src/apps/mqtt/mqtt.c @@ -257,7 +257,7 @@ mqtt_create_request(struct mqtt_request_t *r_objs, u16_t pkt_id, mqtt_request_cb struct mqtt_request_t *r = NULL; u8_t n; LWIP_ASSERT("mqtt_create_request: r_objs != NULL", r_objs != NULL); - for (n = 0; n < MQTT_REQ_MAX_IN_FLIGHT && r == NULL; n++) { + for (n = 0; n < MQTT_REQ_MAX_IN_FLIGHT; n++) { /* Item point to itself if not in use */ if (r_objs[n].next == &r_objs[n]) { r = &r_objs[n]; @@ -265,6 +265,7 @@ mqtt_create_request(struct mqtt_request_t *r_objs, u16_t pkt_id, mqtt_request_cb r->cb = cb; r->arg = arg; r->pkt_id = pkt_id; + break; } } return r;