From 987f6237c4d1c5866fea840a5ea46ae4d59f1ecd Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Sun, 30 Aug 2015 17:16:20 +0200 Subject: [PATCH] PPP, MPPE, drop input/output packets if we couldn't find the chosen decompressor/compressor Drop input/output packets if we couldn't find a decompressor/compressor, it can't really happen because we only negotiate what we are able to compress/decompress, but for the sake of code consistency it makes much more sense to do so. --- src/netif/ppp/ppp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index c11bb7b1..b9a75a06 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -530,7 +530,7 @@ static err_t ppp_netif_output(struct netif *netif, struct pbuf *pb, u16_t protoc return err; #endif /* MPPE_SUPPORT */ default: - break; + goto err_rte_drop; /* Cannot really happen, we only negotiate what we are able to do */ } } #endif /* CCP_SUPPORT */ @@ -790,7 +790,7 @@ void ppp_input(ppp_pcb *pcb, struct pbuf *pb) { break; #endif /* MPPE_SUPPORT */ default: - break; + goto drop; /* Cannot really happen, we only negotiate what we are able to do */ } /* Assume no PFC */