mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-25 00:14:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

lwip_itoa: fix converting 0 (bug #51729)

Browse Source 
lwip_itoa would output the number 0 as \0.  This fixes the issue by
adding a special check before the normal conversion loop

This was found via shell cmd idxtoname and win32 port.  "lo0" should
be returned for index 1
This commit is contained in:
Joel Cunningham 2017-08-11 10:16:50 -05:00
parent 0cf405e24f
commit 9844049cb1
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG
View File

@ -71,6 +71,9 @@ HISTORY
++ Bugfixes: ++ Bugfixes:
2017-08-11: Joel Cunningham
* lwip_itoa: fix converting the number 0 (previously converted to '\0') (bug #51729)
2017-08-08: Dirk Ziegelmeier 2017-08-08: Dirk Ziegelmeier
* ip4_route_src: parameter order is reversed: ip4_route_src(dest, src) -> ip4_route_src(src, dest) * ip4_route_src: parameter order is reversed: ip4_route_src(dest, src) -> ip4_route_src(src, dest)
to make parameter order consistent with other ip*_route*() functions to make parameter order consistent with other ip*_route*() functions

5
src/core/def.c
View File

@ -217,6 +217,11 @@ lwip_itoa(char* result, size_t bufsize, int number)
/* create the string in a temporary buffer since we don't know how long /* create the string in a temporary buffer since we don't know how long
it will get */ it will get */
tmp = &result[bufsize-2]; tmp = &result[bufsize-2];
if (n == 0) {
*tmp = '0';
tmp--;
result_len++;
}
while ((n != 0) && (result_len < (bufsize - 1))) { while ((n != 0) && (result_len < (bufsize - 1))) {
char val = (char)('0' + (n % 10)); char val = (char)('0' + (n % 10));
*tmp = val; *tmp = val;