From 9071db11afa431577c5076839ce0ae34b77a2a53 Mon Sep 17 00:00:00 2001 From: Simon Goldschmidt Date: Thu, 22 Nov 2018 12:54:50 +0100 Subject: [PATCH] snmp: don't allocat outbound msg for GET RESP (inform cb) --- src/apps/snmp/snmp_msg.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/apps/snmp/snmp_msg.c b/src/apps/snmp/snmp_msg.c index 5ea5ec39..8b2b8a82 100644 --- a/src/apps/snmp/snmp_msg.c +++ b/src/apps/snmp/snmp_msg.c @@ -298,6 +298,16 @@ snmp_receive(void *handle, struct pbuf *p, const ip_addr_t *source_ip, u16_t por err = snmp_parse_inbound_frame(&request); if (err == ERR_OK) { + if (request.request_type == SNMP_ASN1_CONTEXT_PDU_GET_RESP) { + if (request.error_status == SNMP_ERR_NOERROR) { + /* If callback function has been defined call it. */ + if (snmp_inform_callback != NULL) { + snmp_inform_callback(&request, snmp_inform_callback_arg); + } + } + /* stop further handling of GET RESP PDU, we are an agent */ + return; + } err = snmp_prepare_outbound_frame(&request); if (err == ERR_OK) { @@ -311,11 +321,6 @@ snmp_receive(void *handle, struct pbuf *p, const ip_addr_t *source_ip, u16_t por err = snmp_process_getbulk_request(&request); } else if (request.request_type == SNMP_ASN1_CONTEXT_PDU_SET_REQ) { err = snmp_process_set_request(&request); - } else if(request.request_type == SNMP_ASN1_CONTEXT_PDU_GET_RESP) { - /* If callback function has been defined call it. */ - if (snmp_inform_callback != NULL) { - snmp_inform_callback(&request, snmp_inform_callback_arg); - } } } #if LWIP_SNMP_V3 @@ -379,7 +384,7 @@ snmp_receive(void *handle, struct pbuf *p, const ip_addr_t *source_ip, u16_t por } #endif - if ((err == ERR_OK) && (request.request_type != SNMP_ASN1_CONTEXT_PDU_GET_RESP)) { + if (err == ERR_OK) { err = snmp_complete_outbound_frame(&request); if (err == ERR_OK) {