mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-02-06 09:39:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

ip.c: Fix bug #21846 "LwIP doesn't appear to perform any IP Source Address Filtering" reported by Tom Evans.

Browse Source
This commit is contained in:
fbernon 2007-12-30 01:09:11 +00:00
parent 1ed34774c8
commit 8d39b1a152
2 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG
View File

@ -19,6 +19,10 @@ HISTORY
++ New features: ++ New features:
2007-12-31 Frédéric Bernon, Tom Evans
* ip.c: Fix bug #21846 "LwIP doesn't appear to perform any IP Source Address
Filtering" reported by Tom Evans.
2007-12-21 Frédéric Bernon, Simon Goldschmidt, Jonathan Larmour 2007-12-21 Frédéric Bernon, Simon Goldschmidt, Jonathan Larmour
* tcp.h, opt.h, api.h, api_msg.h, tcp.c, tcp_in.c, api_lib.c, api_msg.c, * tcp.h, opt.h, api.h, api_msg.h, tcp.c, tcp_in.c, api_lib.c, api_msg.c,
sockets.c, init.c: task #7252: Implement TCP listen backlog: Warning: raw API sockets.c, init.c: task #7252: Implement TCP listen backlog: Warning: raw API

23
src/core/ipv4/ip.c
View File

@ -178,6 +178,9 @@ ip_input(struct pbuf *p, struct netif *inp)
struct ip_hdr *iphdr; struct ip_hdr *iphdr;
struct netif *netif; struct netif *netif;
u16_t iphdrlen; u16_t iphdrlen;
#if LWIP_DHCP
int ipsrcchecking=1;
#endif /* LWIP_DHCP */
IP_STATS_INC(ip.recv); IP_STATS_INC(ip.recv);
snmp_inc_ipinreceives(); snmp_inc_ipinreceives();
@ -193,6 +196,7 @@ ip_input(struct pbuf *p, struct netif *inp)
snmp_inc_ipinhdrerrors(); snmp_inc_ipinhdrerrors();
return ERR_OK; return ERR_OK;
} }
/* obtain IP header length in number of 32-bit words */ /* obtain IP header length in number of 32-bit words */
iphdrlen = IPH_HL(iphdr); iphdrlen = IPH_HL(iphdr);
/* calculate IP header length in bytes */ /* calculate IP header length in bytes */
@ -288,10 +292,29 @@ ip_input(struct pbuf *p, struct netif *inp)
if (ntohs(((struct udp_hdr *)((u8_t *)iphdr + iphdrlen))->dest) == DHCP_CLIENT_PORT) { if (ntohs(((struct udp_hdr *)((u8_t *)iphdr + iphdrlen))->dest) == DHCP_CLIENT_PORT) {
LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE | 1, ("ip_input: DHCP packet accepted.\n")); LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE | 1, ("ip_input: DHCP packet accepted.\n"));
netif = inp; netif = inp;
ipsrcchecking = 0;
} }
} }
} }
#endif /* LWIP_DHCP */ #endif /* LWIP_DHCP */
/* broadcast or multicast packet source address? Compliant with RFC 1122: 3.2.1.3 */
#if LWIP_DHCP
if (ipsrcchecking)
#endif /* LWIP_DHCP */
{ if ((ip_addr_isbroadcast(&(iphdr->src), inp)) ||
(ip_addr_ismulticast(&(iphdr->src)))) {
/* packet source is not valid */
LWIP_DEBUGF(IP_DEBUG | LWIP_DBG_TRACE | 1, ("ip_input: packet source is not valid.\n"));
/* free (drop) packet pbufs */
pbuf_free(p);
IP_STATS_INC(ip.drop);
snmp_inc_ipinaddrerrors();
snmp_inc_ipindiscards();
return ERR_OK;
}
}
/* packet not for us? */ /* packet not for us? */
if (netif == NULL) { if (netif == NULL) {
/* packet not for us, route or discard */ /* packet not for us, route or discard */