mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-07-07 13:29:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue in pbuf_take(): old pbuf of type PBUF_REF was being referenced

Browse Source 
after being freed. Also, it was not being freed if it had been the first
buffer in chain. It still needs to be freed then.
This commit is contained in:
davidhaas 2003-03-31 21:32:30 +00:00
parent 9f3511231a
commit 82a32be1d6
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/core/pbuf.c
View File

@ -825,13 +825,6 @@ pbuf_take(struct pbuf *f)
/* prev->next == p at this point */
/* break chain and insert new pbuf instead */
prev->next = q;
/* p is no longer pointed to by prev or by our caller,
* as the caller must do p = pbuf_take(p); so free it
* from reference through linkage.
* note that we have set p->next to NULL already so that
* we will not free the rest of the chain by accident.
*/
pbuf_free(p);
/* prev == NULL, so we replaced the top pbuf of the chain */
} else
top = q;
@ -842,6 +835,13 @@ pbuf_take(struct pbuf *f)
/* do not copy ref, since someone else might be using the old buffer */
/* pbuf is not freed, as this is the responsibility of the application */
DEBUGF(PBUF_DEBUG, ("pbuf_take: replaced PBUF_REF %p with %p\n", (void *)p, (void *)q));
/* p is no longer pointed to by prev or by our caller,
* as the caller must do p = pbuf_take(p); so free it
* from reference through linkage.
* note that we have set p->next to NULL already so that
* we will not free the rest of the chain by accident.
*/
pbuf_free(p);
p = q;
}
else