mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-28 09:19:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize sendmsg UDP pbuf chain creation

Browse Source 
This commit optimizes the sendmsg UDP pbuf chain creation by not
allocating/freeing a netbuf per io vector and instead building a pbuf
chain directly in the sockets layer
This commit is contained in:
Joel Cunningham 2016-03-02 16:16:33 -06:00
parent 076795562e
commit 80cc988f2f
1 changed files with 21 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
src/api/sockets.c
View File

@ -1071,27 +1071,28 @@ lwip_sendmsg(int s, const struct msghdr *msg, int flags)
err = ERR_OK; err = ERR_OK;
} }
#else /* LWIP_NETIF_TX_SINGLE_PBUF */ #else /* LWIP_NETIF_TX_SINGLE_PBUF */
/* create a chained netbuf from the IO vectors */ /* create a chained netbuf from the IO vectors. NOTE: we assemble a pbuf chain
err = netbuf_ref(chain_buf, msg->msg_iov[0].iov_base, (u16_t)msg->msg_iov[0].iov_len); manually to avoid having to allocate, chain, and delete a netbuf for each iov */
if (err == ERR_OK) { for (i = 0; i < msg->msg_iovlen; i++) {
struct netbuf *tail_buf; struct pbuf *p = pbuf_alloc(PBUF_TRANSPORT, 0, PBUF_REF);
size = msg->msg_iov[0].iov_len; if (p == NULL) {
for (i = 1; i < msg->msg_iovlen; i++) { err = ERR_MEM; /* let netbuf_delete() cleanup chain_buf */
tail_buf = netbuf_new();
if (!tail_buf) {
err = ERR_MEM;
break;
} else {
err = netbuf_ref(tail_buf, msg->msg_iov[i].iov_base, (u16_t)msg->msg_iov[i].iov_len);
if (err == ERR_OK) {
netbuf_chain(chain_buf, tail_buf);
size += msg->msg_iov[i].iov_len;
} else {
netbuf_delete(tail_buf);
break; break;
} }
p->payload = msg->msg_iov[i].iov_base;
LWIP_ASSERT("iov_len < u16_t", msg->msg_iov[i].iov_len <= 0xFFFF);
p->len = p->tot_len = (u16_t)msg->msg_iov[i].iov_len;
/* netbuf empty, add new pbuf */
if (chain_buf->p == NULL) {
chain_buf->p = chain_buf->ptr = p;
/* add pbuf to existing pbuf chain */
} else {
pbuf_cat(chain_buf->p, p);
} }
} }
/* save size of total chain */
if (err == ERR_OK) {
size = netbuf_len(chain_buf);
} }
#endif /* LWIP_NETIF_TX_SINGLE_PBUF */ #endif /* LWIP_NETIF_TX_SINGLE_PBUF */