mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-01-15 22:49:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

icmp: Fix memory leak in icmp_input() error paths

Browse Source 
Ensure the newly allocated packet buffer is freed in error paths.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
This commit is contained in:
Axel Lin 2015-12-03 17:48:55 +08:00 committed by Dirk Ziegelmeier
parent 3b60c855e1
commit 7f92660598
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/ipv4/icmp.c
View File

@ -164,11 +164,13 @@ icmp_input(struct pbuf *p, struct netif *inp)
/* switch r->payload back to icmp header */ /* switch r->payload back to icmp header */
if (pbuf_header(r, -hlen)) { if (pbuf_header(r, -hlen)) {
LWIP_ASSERT("icmp_input: moving r->payload to icmp header failed\n", 0); LWIP_ASSERT("icmp_input: moving r->payload to icmp header failed\n", 0);
pbuf_free(r);
goto icmperr; goto icmperr;
} }
/* copy the rest of the packet without ip header */ /* copy the rest of the packet without ip header */
if (pbuf_copy(r, p) != ERR_OK) { if (pbuf_copy(r, p) != ERR_OK) {
LWIP_ASSERT("icmp_input: copying to new pbuf failed\n", 0); LWIP_ASSERT("icmp_input: copying to new pbuf failed\n", 0);
pbuf_free(r);
goto icmperr; goto icmperr;
} }
/* free the original p */ /* free the original p */