fixed bug #34360 tcp_shutdown: RST on unacked is not send when shutting down both rx AND tx

This commit is contained in:
Simon Goldschmidt 2011-09-22 21:38:56 +02:00
parent e145c1d31c
commit 797f26e45b
2 changed files with 12 additions and 7 deletions

View File

@ -65,6 +65,10 @@ HISTORY
++ Bugfixes:
2011-09-22: Simon Goldschmidt
* tcp.c: fixed bug #34360 tcp_shutdown: RST on unacked is not send when
shutting down both rx AND tx
2011-09-22: Simon Goldschmidt
* tcp_impl.h: fixed bug #34355: nagle does not take snd_buf/snd_queuelen into
account

View File

@ -305,12 +305,7 @@ tcp_shutdown(struct tcp_pcb *pcb, int shut_rx, int shut_tx)
return ERR_CONN;
}
if (shut_rx) {
/* shut down the receive side: free buffered data... */
if (pcb->refused_data != NULL) {
pbuf_free(pcb->refused_data);
pcb->refused_data = NULL;
}
/* ... and set a flag not to receive any more data */
/* shut down the receive side: set a flag not to receive any more data */
pcb->flags |= TF_RXCLOSED;
}
if (shut_tx) {
@ -320,12 +315,18 @@ tcp_shutdown(struct tcp_pcb *pcb, int shut_rx, int shut_tx)
case SYN_RCVD:
case ESTABLISHED:
case CLOSE_WAIT:
return tcp_close_shutdown(pcb, 0);
/* if shut_tx AND shut_rx, send RST if we have unacked data */
return tcp_close_shutdown(pcb, (u8_t)shut_rx);
default:
/* don't shut down other states */
break;
}
}
if (shut_rx && (pcb->refused_data != NULL)) {
/* shut down the receive side: free buffered data if we come here */
pbuf_free(pcb->refused_data);
pcb->refused_data = NULL;
}
/* @todo: return another err_t if not in correct state or already shut? */
return ERR_OK;
}