mirror of
https://github.com/lwip-tcpip/lwip.git
synced 2024-09-17 20:24:24 +00:00
SNMP: SMEMCPY should only be used when size is known at compile time
This commit is contained in:
parent
e041b9a51c
commit
76094b8c7e
@ -940,7 +940,7 @@ snmp_next_oid_check(struct snmp_next_oid_state *state, const u32_t *oid, const u
|
|||||||
{
|
{
|
||||||
if (oid_len <= state->next_oid_max_len)
|
if (oid_len <= state->next_oid_max_len)
|
||||||
{
|
{
|
||||||
SMEMCPY(state->next_oid, oid, oid_len * sizeof(u32_t));
|
MEMCPY(state->next_oid, oid, oid_len * sizeof(u32_t));
|
||||||
state->next_oid_len = oid_len;
|
state->next_oid_len = oid_len;
|
||||||
state->status = SNMP_NEXT_OID_STATUS_SUCCESS;
|
state->status = SNMP_NEXT_OID_STATUS_SUCCESS;
|
||||||
state->reference = reference;
|
state->reference = reference;
|
||||||
|
@ -1021,7 +1021,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
|
|||||||
break;
|
break;
|
||||||
case 2: /* ifDescr */
|
case 2: /* ifDescr */
|
||||||
value_len = sizeof(netif->name);
|
value_len = sizeof(netif->name);
|
||||||
SMEMCPY(value, netif->name, value_len);
|
MEMCPY(value, netif->name, value_len);
|
||||||
break;
|
break;
|
||||||
case 3: /* ifType */
|
case 3: /* ifType */
|
||||||
*value_s32 = netif->link_type;
|
*value_s32 = netif->link_type;
|
||||||
@ -1037,7 +1037,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
|
|||||||
break;
|
break;
|
||||||
case 6: /* ifPhysAddress */
|
case 6: /* ifPhysAddress */
|
||||||
value_len = sizeof(netif->hwaddr);
|
value_len = sizeof(netif->hwaddr);
|
||||||
SMEMCPY(value, &netif->hwaddr, value_len);
|
MEMCPY(value, &netif->hwaddr, value_len);
|
||||||
break;
|
break;
|
||||||
case 7: /* ifAdminStatus */
|
case 7: /* ifAdminStatus */
|
||||||
if (netif_is_up(netif)) {
|
if (netif_is_up(netif)) {
|
||||||
@ -1114,7 +1114,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
|
|||||||
/** @note returning zeroDotZero (0.0) no media specific MIB support */
|
/** @note returning zeroDotZero (0.0) no media specific MIB support */
|
||||||
case 22: /* ifSpecific */
|
case 22: /* ifSpecific */
|
||||||
value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
|
value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
|
||||||
SMEMCPY(value, snmp_zero_dot_zero.id, value_len);
|
MEMCPY(value, snmp_zero_dot_zero.id, value_len);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
return 0;
|
return 0;
|
||||||
|
@ -356,7 +356,7 @@ snmp_table_extract_value_from_u32ref(struct snmp_node_instance* instance, void*
|
|||||||
u16_t
|
u16_t
|
||||||
snmp_table_extract_value_from_refconstptr(struct snmp_node_instance* instance, void* value)
|
snmp_table_extract_value_from_refconstptr(struct snmp_node_instance* instance, void* value)
|
||||||
{
|
{
|
||||||
SMEMCPY(value, instance->reference.const_ptr, instance->reference_len);
|
MEMCPY(value, instance->reference.const_ptr, instance->reference_len);
|
||||||
return (u16_t)instance->reference_len;
|
return (u16_t)instance->reference_len;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user