mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2025-03-12 13:13:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

SNMP: SMEMCPY should only be used when size is known at compile time

Browse Source
This commit is contained in:
Dirk Ziegelmeier 2016-01-05 09:59:42 +01:00
parent e041b9a51c
commit 76094b8c7e
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/apps/snmp/snmp_core.c
View File

@ -940,7 +940,7 @@ snmp_next_oid_check(struct snmp_next_oid_state *state, const u32_t *oid, const u
{
if (oid_len <= state->next_oid_max_len)
{
SMEMCPY(state->next_oid, oid, oid_len * sizeof(u32_t));
MEMCPY(state->next_oid, oid, oid_len * sizeof(u32_t));
state->next_oid_len = oid_len;
state->status = SNMP_NEXT_OID_STATUS_SUCCESS;
state->reference = reference;

6
src/apps/snmp/snmp_mib2.c
View File

@ -1021,7 +1021,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
break;
case 2: /* ifDescr */
value_len = sizeof(netif->name);
SMEMCPY(value, netif->name, value_len);
MEMCPY(value, netif->name, value_len);
break;
case 3: /* ifType */
*value_s32 = netif->link_type;
@ -1037,7 +1037,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
break;
case 6: /* ifPhysAddress */
value_len = sizeof(netif->hwaddr);
SMEMCPY(value, &netif->hwaddr, value_len);
MEMCPY(value, &netif->hwaddr, value_len);
break;
case 7: /* ifAdminStatus */
if (netif_is_up(netif)) {
@ -1114,7 +1114,7 @@ static u16_t interfaces_Table_get_value(struct snmp_node_instance* instance, voi
/** @note returning zeroDotZero (0.0) no media specific MIB support */
case 22: /* ifSpecific */
value_len = snmp_zero_dot_zero.len * sizeof(u32_t);
SMEMCPY(value, snmp_zero_dot_zero.id, value_len);
MEMCPY(value, snmp_zero_dot_zero.id, value_len);
break;
default:
return 0;

2
src/apps/snmp/snmp_table.c
View File

@ -356,7 +356,7 @@ snmp_table_extract_value_from_u32ref(struct snmp_node_instance* instance, void*
u16_t
snmp_table_extract_value_from_refconstptr(struct snmp_node_instance* instance, void* value)
{
SMEMCPY(value, instance->reference.const_ptr, instance->reference_len);
MEMCPY(value, instance->reference.const_ptr, instance->reference_len);
return (u16_t)instance->reference_len;
}