mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-10-05 22:29:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Free NAT entries on remove (fixes a memory leak)

Browse Source
This commit is contained in:
goldsimon 2010-05-05 19:39:29 +00:00
parent a7fdb67e8f
commit 67d8c7999a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/core/ipv4/ip_nat.c
View File

@ -43,7 +43,6 @@
* them. * them.
* *
* - netif_remove must notify NAT code when a NAT'ed interface is removed * - netif_remove must notify NAT code when a NAT'ed interface is removed
* - free NAT entries on remove?
* - allocate NAT entries from a new memp pool instead of the heap * - allocate NAT entries from a new memp pool instead of the heap
* - let ttl be ticks, not seconds * - let ttl be ticks, not seconds
* *
@ -294,8 +293,8 @@ ip_nat_remove(const ip_nat_entry_t *remove_entry)
LWIP_ASSERT("NULL != previous", NULL != previous); LWIP_ASSERT("NULL != previous", NULL != previous);
previous->next = next; previous->next = next;
} }
/* @todo: free 'cur' or there will be a memory leak !?! */ /* free 'cur' or there will be a memory leak */
/* ip_nat_free(cur); */ ip_nat_free(cur);
return; return;
} else { } else {
previous = cur; previous = cur;