From 5b6c654dd112ab1f9d18a598994776c0714d3f55 Mon Sep 17 00:00:00 2001
From: goldsimon <goldsimon@gmx.de>
Date: Wed, 29 Mar 2017 20:54:24 +0200
Subject: [PATCH] make F_GETFL return file access mode for !CORE_LOCKING as
 well

---
 src/api/sockets.c | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/src/api/sockets.c b/src/api/sockets.c
index 3763b653..c250f62c 100644
--- a/src/api/sockets.c
+++ b/src/api/sockets.c
@@ -3171,19 +3171,30 @@ lwip_fcntl(int s, int cmd, int val)
     if (NETCONNTYPE_GROUP(netconn_type(sock->conn)) == NETCONN_TCP) {
 #if LWIP_TCPIP_CORE_LOCKING
       LOCK_TCPIP_CORE();
-      LWIP_ASSERT("sock->conn->pcb.tcp != NULL", sock->conn->pcb.tcp != NULL);
-      if(!(sock->conn->pcb.tcp->flags & TF_RXCLOSED)) {
-        op_mode |= O_RDONLY;
-      }
-      if (!(sock->conn->pcb.tcp->flags & TF_FIN)) {
-        op_mode |= O_WRONLY;
+#else
+      SYS_ARCH_DECL_PROTECT(lev);
+      /* the proper thing to do here would be to get into the tcpip_thread,
+         but locking should be OK as well since we only *read* some flags */
+      SYS_ARCH_PROTECT(lev);
+#endif
+      if (sock->conn && sock->conn->pcb.tcp) {
+        if(!(sock->conn->pcb.tcp->flags & TF_RXCLOSED)) {
+          op_mode |= O_RDONLY;
+        }
+        if (!(sock->conn->pcb.tcp->flags & TF_FIN)) {
+          op_mode |= O_WRONLY;
+        }
       }
+#if LWIP_TCPIP_CORE_LOCKING
       UNLOCK_TCPIP_CORE();
-#endif /* !LWIP_TCPIP_CORE_LOCKING */
+#else
+      SYS_ARCH_UNPROTECT(lev);
+#endif
     } else {
       op_mode |= O_RDWR;
     }
 
+    /* ensure O_RDWR for (O_RDONLY|O_WRONLY) != O_RDWR cases */
     ret |= (op_mode == (O_RDONLY|O_WRONLY)) ? O_RDWR : op_mode;
 
     break;