From 406874b6c2b242112018dcd05d88f58fb1de7e85 Mon Sep 17 00:00:00 2001 From: goldsimon Date: Wed, 30 Apr 2014 13:50:18 +0200 Subject: [PATCH] snmp: added missing default cases (only used for trace output) --- src/core/snmp/mib2.c | 45 +++++++++++++++++++++++++++++++++++++++++ src/core/snmp/msg_in.c | 6 ++++++ src/core/snmp/msg_out.c | 6 ++++++ 3 files changed, 57 insertions(+) diff --git a/src/core/snmp/mib2.c b/src/core/snmp/mib2.c index 0c9ba9f2..553b4de2 100644 --- a/src/core/snmp/mib2.c +++ b/src/core/snmp/mib2.c @@ -2198,6 +2198,9 @@ system_get_value(struct obj_def *od, u16_t len, void *value) *sint_ptr = sysservices; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_get_value(): unknown id: %d\n", id)); + break; }; } @@ -2233,6 +2236,9 @@ system_set_test(struct obj_def *od, u16_t len, void *value) set_ok = 1; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_set_test(): unknown id: %d\n", id)); + break; }; return set_ok; } @@ -2259,6 +2265,9 @@ system_set_value(struct obj_def *od, u16_t len, void *value) MEMCPY(syslocation_ptr, value, len); *syslocation_len_ptr = (u8_t)len; break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("system_set_value(): unknown id: %d\n", id)); + break; }; } @@ -2579,6 +2588,9 @@ ifentry_get_value(struct obj_def *od, u16_t len, void *value) case 22: /* ifSpecific */ MEMCPY(value, ifspecific.id, len); break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ifentry_get_value(): unknown id: %d\n", id)); + break; }; } @@ -2730,6 +2742,9 @@ atentry_get_value(struct obj_def *od, u16_t len, void *value) *dst = *ipaddr_ret; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("atentry_get_value(): unknown id: %d\n", id)); + break; } } #endif /* LWIP_ARP */ @@ -2942,6 +2957,9 @@ ip_get_value(struct obj_def *od, u16_t len, void *value) *uint_ptr = iproutingdiscards; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_get_value(): unknown id: %d\n", id)); + break; }; } @@ -2985,6 +3003,9 @@ ip_set_test(struct obj_def *od, u16_t len, void *value) set_ok = 1; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_set_test(): unknown id: %d\n", id)); + break; }; return set_ok; } @@ -3102,6 +3123,9 @@ ip_addrentry_get_value(struct obj_def *od, u16_t len, void *value) #endif } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_addrentry_get_value(): unknown id: %d\n", id)); + break; } } } @@ -3323,6 +3347,9 @@ ip_rteentry_get_value(struct obj_def *od, u16_t len, void *value) case 13: /* ipRouteInfo */ MEMCPY(value, iprouteinfo.id, len); break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_rteentry_get_value(): unknown id: %d\n", id)); + break; } } } @@ -3428,6 +3455,9 @@ ip_ntomentry_get_value(struct obj_def *od, u16_t len, void *value) *sint_ptr = 3; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("ip_ntomentry_get_value(): unknown id: %d\n", id)); + break; } } #endif /* LWIP_ARP */ @@ -3546,6 +3576,9 @@ icmp_get_value(struct obj_def *od, u16_t len, void *value) case 26: /* icmpOutAddrMaskReps */ *uint_ptr = icmpoutaddrmaskreps; break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("icmp_get_value(): unknown id: %d\n", id)); + break; } } @@ -3683,6 +3716,9 @@ tcp_get_value(struct obj_def *od, u16_t len, void *value) case 15: /* tcpOutRsts */ *uint_ptr = tcpoutrsts; break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("tcp_get_value(): unknown id: %d\n", id)); + break; } } #ifdef THIS_SEEMS_UNUSED @@ -3803,6 +3839,9 @@ udp_get_value(struct obj_def *od, u16_t len, void *value) case 4: /* udpOutDatagrams */ *uint_ptr = udpoutdatagrams; break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("udp_get_value(): unknown id: %d\n", id)); + break; } } @@ -3884,6 +3923,9 @@ udpentry_get_value(struct obj_def *od, u16_t len, void *value) *sint_ptr = pcb->local_port; } break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("udpentry_get_value(): unknown id: %d\n", id)); + break; } } } @@ -4051,6 +4093,9 @@ snmp_get_value(struct obj_def *od, u16_t len, void *value) case 30: /* snmpEnableAuthenTraps */ *uint_ptr = *snmpenableauthentraps_ptr; break; + default: + LWIP_DEBUGF(SNMP_MIB_DEBUG,("snmp_get_value(): unknown id: %d\n", id)); + break; }; } diff --git a/src/core/snmp/msg_in.c b/src/core/snmp/msg_in.c index be940c62..662deec9 100644 --- a/src/core/snmp/msg_in.c +++ b/src/core/snmp/msg_in.c @@ -1067,6 +1067,9 @@ snmp_pdu_header_check(struct pbuf *p, u16_t ofs, u16_t pdu_len, u16_t *ofs_ret, } switch (m_stat->error_status) { + case SNMP_ES_NOERROR: + /* nothing to do */ + break; case SNMP_ES_TOOBIG: snmp_inc_snmpintoobigs(); break; @@ -1082,6 +1085,9 @@ snmp_pdu_header_check(struct pbuf *p, u16_t ofs, u16_t pdu_len, u16_t *ofs_ret, case SNMP_ES_GENERROR: snmp_inc_snmpingenerrs(); break; + default: + LWIP_DEBUGF(SNMP_MSG_DEBUG, ("snmp_pdu_header_check(): unknown error_status: %d\n", m_stat->error_status)); + break; } ofs += (1 + len_octets + len); snmp_asn1_dec_type(p, ofs, &type); diff --git a/src/core/snmp/msg_out.c b/src/core/snmp/msg_out.c index fc0807c5..4c70952b 100644 --- a/src/core/snmp/msg_out.c +++ b/src/core/snmp/msg_out.c @@ -149,6 +149,9 @@ snmp_send_response(struct snmp_msg_pstat *m_stat) switch (m_stat->error_status) { + case SNMP_ES_NOERROR: + /* nothing to do */ + break; case SNMP_ES_TOOBIG: snmp_inc_snmpouttoobigs(); break; @@ -161,6 +164,9 @@ snmp_send_response(struct snmp_msg_pstat *m_stat) case SNMP_ES_GENERROR: snmp_inc_snmpoutgenerrs(); break; + default: + LWIP_DEBUGF(SNMP_MSG_DEBUG, ("snmp_send_response(): unknown error_status: %d\n", m_stat->error_status)); + break; } snmp_inc_snmpoutgetresponses(); snmp_inc_snmpoutpkts();