From 3f47b04f16a874c05def88dcda6b3e0a2d6684ce Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Thu, 9 Apr 2020 03:51:41 +0200 Subject: [PATCH] PPP: add FIXME about removing netif_set_up() call later User application code should be responsible to call netif_set_up() but let's not break compatibility for now. Signed-off-by: Sylvain Rochet --- src/netif/ppp/ppp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index 6b426130..c16ce9eb 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -706,6 +706,8 @@ ppp_pcb *ppp_new(struct netif *pppif, const struct link_callbacks *callbacks, vo PPPDEBUG(LOG_ERR, ("ppp_new: netif_add failed\n")); return NULL; } + /* FIXME: user application should be responsible to call netif_set_up(), + * remove it for next release with allowed behavior break */ netif_set_up(pcb->netif); pcb->link_cb = callbacks;