From 35c670513fde8839be911c5153f5e0c685356bac Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Sun, 22 Jul 2012 23:53:27 +0200 Subject: [PATCH] fixed some more PPP phase state machine issues The only way PPPoE or PPPoL2TP disconnect it through ppp_link_terminated(), therefore PPP is always already down, so we don't need to ask PPP to hup or stop. --- src/netif/ppp/ppp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/netif/ppp/ppp.c b/src/netif/ppp/ppp.c index f9a1cba3..221f961b 100644 --- a/src/netif/ppp/ppp.c +++ b/src/netif/ppp/ppp.c @@ -1950,8 +1950,6 @@ static void ppp_over_ethernet_link_status_cb(ppp_pcb *pcb, int state) { case PPPOE_CB_STATE_DOWN: PPPDEBUG(LOG_INFO, ("ppp_over_ethernet_link_status_cb: unit %d: DOWN, disconnected\n", pcb->num)); pppoe_err_code = PPPERR_CONNECT; - ppp_hup(pcb); - ppp_stop(pcb); break; /* PPPoE link failed to setup (i.e. PADI/PADO timeout) */ @@ -2001,8 +1999,6 @@ static void ppp_over_l2tp_link_status_cb(ppp_pcb *pcb, int state) { case PPPOL2TP_CB_STATE_DOWN: PPPDEBUG(LOG_INFO, ("ppp_over_l2tp_link_status_cb: unit %d: DOWN, disconnected\n", pcb->num)); pppol2tp_err_code = PPPERR_CONNECT; - ppp_hup(pcb); - ppp_stop(pcb); break; /* PPPoL2TP link failed to setup (i.e. L2TP timeout) */