mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-07-04 20:08:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added a better comment to explain why tcp_close doesn't care for the return value of tcp_output

Browse Source
This commit is contained in:
goldsimon 2007-07-26 09:31:09 +00:00
parent f4036e8352
commit 33054a18db
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/core/tcp.c
View File

@ -190,10 +190,13 @@ tcp_close(struct tcp_pcb *pcb)
} }
if (pcb != NULL && err == ERR_OK) { if (pcb != NULL && err == ERR_OK) {
/* @todo: to ensure all has been sent when tcp_close returns, we have to /* To ensure all data has been sent when tcp_close returns, we have
make sure tcp_output doesn't fail. to make sure tcp_output doesn't fail.
For now (and as long as we don't need this (no LINGER)), it's enough Since we don't really have to ensure all data has been sent when tcp_close
to let the TCP timers deal with this. */ returns (unsent data is sent from tcp timer functions, also), we don't care
for the return value of tcp_output for now. */
/* @todo: When implementing SO_LINGER, this must be changed somehow:
If SOF_LINGER is set, the data should be sent when tcp_close returns. */
tcp_output(pcb); tcp_output(pcb);
} }
return err; return err;
@ -1320,13 +1323,3 @@ tcp_pcbs_sane(void)
} }
#endif /* TCP_DEBUG */ #endif /* TCP_DEBUG */
#endif /* LWIP_TCP */ #endif /* LWIP_TCP */