From 18fcc1d50425817bc9ab85cfc8e74d4a1c9f0ac5 Mon Sep 17 00:00:00 2001 From: Axel Lin Date: Tue, 9 Aug 2016 21:52:13 +0200 Subject: [PATCH] [PATCH] debug: Add braces around empty body in an 'if' statement I have below code in my cc.h: #ifdef MYSDK_LWIP_DEBUG #define LWIP_PLATFORM_ASSERT(x) MYSDK_ASSERTION_FAIL_ACTION() #else #define LWIP_PLATFORM_ASSERT(x) #endif /* ifdef MYSDK_LWIP_DEBUG */ I got below error when in non-debug build: src/include/lwip/debug.h:76:32: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] LWIP_PLATFORM_ASSERT(message); } while(0) ^ Fix the build error by adding braces around empty body in an 'if' statement. Signed-off-by: Axel Lin Signed-off-by: sg --- src/include/lwip/debug.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/include/lwip/debug.h b/src/include/lwip/debug.h index cd6eacff..c6766120 100644 --- a/src/include/lwip/debug.h +++ b/src/include/lwip/debug.h @@ -72,8 +72,8 @@ * -- To disable assertions define LWIP_NOASSERT in arch/cc.h. */ #ifndef LWIP_NOASSERT -#define LWIP_ASSERT(message, assertion) do { if(!(assertion)) \ - LWIP_PLATFORM_ASSERT(message); } while(0) +#define LWIP_ASSERT(message, assertion) do { if (!(assertion)) { \ + LWIP_PLATFORM_ASSERT(message); }} while(0) #ifndef LWIP_PLATFORM_ASSERT #error "If you want to use LWIP_ASSERT, LWIP_PLATFORM_ASSERT(message) needs to be defined in your arch/cc.h" #endif