mirror/lwip
1
0
Fork 0
mirror of https://github.com/lwip-tcpip/lwip.git synced 2024-12-28 00:15:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed bug #47448 (netconn/socket leak if RST is received during close)

Browse Source
This commit is contained in:
sg 2016-03-17 21:49:01 +01:00
parent 93ccba9bcb
commit 149bb36805
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG
View File

@ -302,6 +302,9 @@ HISTORY
++ Bugfixes:
2013-03-17: Simon Goldschmidt
* api_msg.c: fixed bug #47448 (netconn/socket leak if RST is received during close)
2013-03-17: Joel Cunningham
* api_msg.c: don't fail closing a socket/netconn when failing to allocate the
FIN segment; blocking the calling thread for a while is better than risking

12
src/api/api_msg.c
View File

@ -378,13 +378,19 @@ err_tcp(void *arg, err_t err)
conn->pcb.tcp = NULL;
/* no check since this is always fatal! */
SYS_ARCH_SET(conn->last_err, err);
/* reset conn->state now before waking up other threads */
old_state = conn->state;
conn->state = NETCONN_NONE;
if (old_state == NETCONN_CLOSE) {
/* RST during close: let close return success & dealloc the netconn */
err = ERR_OK;
NETCONN_SET_SAFE_ERR(conn, ERR_OK);
} else {
/* no check since this is always fatal! */
SYS_ARCH_SET(conn->last_err, err);
}
/* @todo: the type of NETCONN_EVT created should depend on 'old_state' */
/* Notify the user layer about a connection error. Used to signal select. */