From c2302eba83f7a0831f6cb917ed615b7ae9deda9d Mon Sep 17 00:00:00 2001 From: "T. Joseph Carter" Date: Fri, 6 Mar 2015 20:29:47 -0800 Subject: [PATCH] "Faster" for loop is only "faster" because it was broken --- libretro-fetch.sh | 2 +- script-modules/modules.sh | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libretro-fetch.sh b/libretro-fetch.sh index f33dab20..105d3173 100755 --- a/libretro-fetch.sh +++ b/libretro-fetch.sh @@ -76,7 +76,7 @@ libretro_fetch() { fi [ "$module_dir" != "." ] && echo_cmd "mkdir -p \"$WORKDIR/$module_dir\"" - for i in seq 0 $num_git_urls; do + for (( i=0; i < $num_git_urls; ++i )); do eval "git_url=\$libretro_${1}_mgit_url_$i" eval "git_subdir=\$libretro_${1}_mgit_dir_$i" eval "git_submodules=\$libretro_${1}_mgit_submodules_$i" diff --git a/script-modules/modules.sh b/script-modules/modules.sh index 9006faa3..3cf26f43 100644 --- a/script-modules/modules.sh +++ b/script-modules/modules.sh @@ -5,7 +5,6 @@ register_module() { core|devkit|player) if [ -n "$2" ]; then eval "libretro_${1}s=\"\$libretro_${1}s $2::\"" - echo "Registering $1: $2" else echo "register_module:Trying to register a $1 without a name" exit 1