Tipp Moseley
d995f8a668
Fixes a concurrency error in groupcache. Previously, multiple Get
...
requests could simultaneously result in a load(). Only requests that
enter singleflight Do concurrently would be deduped, so it was possible for
populateCache to be called multiple times for the same key. That
would result in overcounting nbytes, and eventually leading to a
livelock where nbytes > cacheBytes, but there were no entries in the
cache.
Change-Id: I5b304ce82041c1310c31b662486744e86509cc53
2016-01-27 11:33:35 -08:00
Brad Fitzpatrick
604ed57851
Merge pull request #41 from shawnps/patch-1
...
fix wrong number of args for format in Errorf call
2015-01-25 10:08:32 -08:00
Shawn Smith
c6017b7e87
fix wrong number of args for format in Errorf call
2015-01-25 16:07:57 +09:00
Brad Fitzpatrick
86ced4a883
Merge pull request #28 from ryanslade/reduce-allocations
...
Reduce allocations
2014-12-23 10:22:21 -08:00
Ryan Slade
505a8b21f5
Reduce allocations
...
Store temporary buffers in a sync.Pool.
Create one httpGetter per peer when Set() is called so we don't
allocate a new one on each call PickPeer().
2014-12-16 08:18:07 +00:00
Andrew Gerrand
f391194b96
Merge pull request #40 from ukai/protobuf
...
goprotobuf has moved to GitHub
2014-11-25 16:26:21 +11:00
Fumitoshi Ukai
5fb127ef79
goprotobuf has moved to GitHub
...
code.google.com/p/goprotobuf to github.com/golang/groupcache
2014-11-25 13:24:33 +09:00
Andrew Gerrand
d2a1805917
Merge pull request #33 from fumin/master
...
allow all options of HTTPPool to be specified by users
2014-10-20 20:15:39 +11:00
awaw fumin
1568598a4f
allow all options of HTTPPool to be specified by users
2014-10-20 14:40:48 +08:00
Andrew Gerrand
8b25adc0f6
Merge pull request #30 from EverythingMe/fix_replicas
...
changed default number of replicas in http pool hash ring to 50
2014-07-09 07:38:46 +10:00
Dvir Volk
21fc61ac51
changed default number of replicas in http pool hash ring to 50, and fixed hash ring benchmark
2014-07-08 12:15:05 +03:00
Andrew Gerrand
0ba15ac99c
Merge pull request #27 from EverythingMe/remove_extra_unescaping
...
removed extra url-unescaping in http pool
2014-07-07 13:45:50 +10:00
Brad Fitzpatrick
a531d51b7f
Merge pull request #26 from dgryski/consistenthash-binary-search
...
consistenthash: replace linear search with binary search
2014-07-02 13:37:02 -07:00
Dvir Volk
976d66a1f1
removed extra unesacping in http pool that screwed up the keys we were using
2014-06-18 23:00:46 +03:00
Damian Gryski
89ec0544ae
consistenthash: replace linear search with binary search
...
The binary search quickly out-paces the linear search, even for a small
number of shards and replicas.
benchmark old ns/op new ns/op delta
BenchmarkGet8 122 122 +0.00%
BenchmarkGet32 471 137 -70.91%
BenchmarkGet128 5619 254 -95.48%
BenchmarkGet512 90302 406 -99.55%
2014-06-17 17:09:50 +02:00
Brad Fitzpatrick
d781998583
Merge pull request #16 from Obvious/dpup-serverrequests
...
HTTPPool increments Group.Stats.ServerRequests
2013-10-30 09:55:26 -07:00
Dan Pupius
bdcbf83d9e
HTTPPool increments Group.Stats.ServerRequests
2013-10-16 10:57:19 -07:00
Andrew Gerrand
5fd3de064f
Merge pull request #15 from Obvious/master
...
PeerPicker uses ring hash to more consistently choose peers
2013-10-03 20:14:56 -07:00
Dan Pupius
a06134f0da
PeerPicker uses ring hash to pick peers
2013-10-01 19:10:50 -07:00
Andrew Gerrand
df73e837ff
Merge pull request #13 from ukai/fix_http
...
Close body even if it got error http status.
2013-08-29 17:26:52 -07:00
Fumitoshi Ukai
38eed8b4ba
Close body even if it got error http status.
...
Otherwise, http connections keep open if server
returned error status (e.g. Get returned error).
2013-08-29 22:00:01 +09:00
Andrew Gerrand
61c957aaf8
Merge pull request #12 from bmizerany/typo
...
fix doc typo
2013-08-27 16:27:32 -07:00
Blake Mizerany
0fb45dacf0
fix doc typo
2013-08-26 16:42:09 -07:00
Andrew Gerrand
b912ed88a6
Merge branch 'master' of github.com:/golang/groupcache
2013-08-12 12:08:34 +10:00
Andrew Gerrand
3f89d3eb33
fix overflow in peer selection
2013-08-12 12:08:11 +10:00
Andrew Gerrand
9db4a8a999
Merge pull request #8 from Luit/patch-2
...
Weird use of brackets in README.md
2013-07-31 20:35:22 -07:00
Luit van Drongelen
8a39167b88
Weird use of brackets in README.md
2013-07-31 09:45:16 +02:00
Andrew Gerrand
1d5ab13e0b
Merge pull request #7 from Luit/patch-1
...
fix RegisterPeerPicker panic string
(Luit has signed the CLA.)
2013-07-30 23:32:27 -07:00
Luit van Drongelen
e15e6b865b
fix RegisterPeerPicker panic string
2013-07-31 00:28:33 +02:00
Brad Fitzpatrick
0e1c21818b
Merge pull request #2 from elimisteve/patch-1
...
Fixed README typo: s/suppresion/suppression/
2013-07-27 16:12:44 -07:00
Steve Phillips
8b8b9d63cf
Fixed README typo: s/suppresion/suppression/
2013-07-26 15:08:26 -07:00
Brad Fitzpatrick
e8519194be
Remove duplicated unnecessary file. It's in the groupcachepb sub-package.
2013-07-26 13:41:32 -07:00
Andrew Gerrand
b3105e2311
fix RegisterPeerPicker comment
2013-07-24 14:59:50 +10:00
Andrew Gerrand
0bfcb13dbb
add HTTP pool implementation
2013-07-24 14:57:40 +10:00
Andrew Gerrand
e2abff3bea
add docs to PeerPicker
2013-07-24 11:09:53 +10:00
Brad Fitzpatrick
6dad98a783
initial commit.
2013-07-23 18:03:06 -07:00