From b543958475062d1798159e5995210c7395b0c0d3 Mon Sep 17 00:00:00 2001 From: Tommy PAGEARD Date: Mon, 6 Jul 2020 18:53:29 +0200 Subject: [PATCH] fix(datarace): pass peer var as param for func literal peer var was being accessed by scope heritage instead of being passed as param. making it unsafe to data race. --- groupcache.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/groupcache.go b/groupcache.go index 6c0240c..e841ef9 100644 --- a/groupcache.go +++ b/groupcache.go @@ -273,10 +273,10 @@ func (g *Group) Remove(ctx context.Context, key string) error { } wg.Add(1) - go func() { + go func(peer ProtoGetter) { errs <- g.removeFromPeer(ctx, peer, key) wg.Done() - }() + }(peer) } go func() { wg.Wait()