Merge pull request #45 from udhos/master

How to make expiration optional.
This commit is contained in:
Derrick J. Wippler 2022-07-06 09:44:31 -05:00 committed by GitHub
commit 4707649ec3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions

View File

@ -25,11 +25,12 @@ For API docs and examples, see http://godoc.org/github.com/mailgun/groupcache
cluster eventually becomes consistent again.
* Support for expired values. `SetBytes()`, `SetProto()` and `SetString()` now
accept an optional `time.Time{}` which represents a time in the future when the
value will expire. Expiration is handled by the LRU Cache when a `Get()` on a
key is requested. This means no network coordination of expired values is needed.
However this does require that time on all nodes in the cluster is synchronized
for consistent expiration of values.
accept an optional `time.Time` which represents a time in the future when the
value will expire. If you don't want expiration, pass the zero value for
`time.Time` (for instance, `time.Time{}`). Expiration is handled by the LRU Cache
when a `Get()` on a key is requested. This means no network coordination of
expired values is needed. However this does require that time on all nodes in the
cluster is synchronized for consistent expiration of values.
* Now always populating the hotcache. A more complex algorithm is unnecessary
when the LRU cache will ensure the most used values remain in the cache. The

View File

@ -33,6 +33,10 @@ var _ Sink = &byteViewSink{}
//
// Implementation of Getter must call exactly one of the Set methods
// on success.
//
// `e` sets an optional time in the future when the value will expire.
// If you don't want expiration, pass the zero value for
// `time.Time` (for instance, `time.Time{}`).
type Sink interface {
// SetString sets the value to s.
SetString(s string, e time.Time) error