From 38eed8b4ba4e4f9180f6351cab66d29d57f18254 Mon Sep 17 00:00:00 2001 From: Fumitoshi Ukai Date: Thu, 29 Aug 2013 22:00:01 +0900 Subject: [PATCH] Close body even if it got error http status. Otherwise, http connections keep open if server returned error status (e.g. Get returned error). --- http.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http.go b/http.go index e1fde7f..b131ed9 100644 --- a/http.go +++ b/http.go @@ -174,10 +174,10 @@ func (h *httpGetter) Get(context Context, in *pb.GetRequest, out *pb.GetResponse if err != nil { return err } + defer res.Body.Close() if res.StatusCode != http.StatusOK { return fmt.Errorf("server returned: %v", res.Status) } - defer res.Body.Close() // TODO: avoid this garbage. b, err := ioutil.ReadAll(res.Body) if err != nil {