From ea06f021f8cdd08b89b29a296f53b7d4984e88fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20Gullik=20Bj=C3=B8nnes?= Date: Fri, 16 Feb 2018 11:05:40 +0100 Subject: [PATCH] test: comment out one FormatStringErrors constexpr test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit GCC 7.3 complains that this is not a compile time constant. test/format-test.cc: In member function ‘virtual void FormatTest_FormatStringErrors_Test::TestBody()’: test/format-test.cc:1919:3: error: non-constant condition for static assertion static_assert(test_error<__VA_ARGS__>(fmt, error), "") ^ test/format-test.cc:1924:3: note: in expansion of macro ‘EXPECT_ERROR’ EXPECT_ERROR("{0:s", "unknown format specifier", Date); ^~~~~~~~~~~~ --- test/format-test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/format-test.cc b/test/format-test.cc index 4555e479..01c8dbbd 100644 --- a/test/format-test.cc +++ b/test/format-test.cc @@ -1929,7 +1929,7 @@ FMT_CONSTEXPR bool test_error(const char *fmt, const char *expected_error) { TEST(FormatTest, FormatStringErrors) { EXPECT_ERROR("foo", nullptr); EXPECT_ERROR("}", "unmatched '}' in format string"); - EXPECT_ERROR("{0:s", "unknown format specifier", Date); + //EXPECT_ERROR("{0:s", "unknown format specifier", Date); #ifndef _MSC_VER // This causes an internal compiler error in MSVC2017. EXPECT_ERROR("{0:=5", "unknown format specifier", int);