1
0
mirror of https://github.com/fmtlib/fmt.git synced 2025-03-30 13:20:18 +00:00

Upgrade module-test to msvc 16.11.5 and 17.0-pre5 ()

This commit is contained in:
Daniela Engert 2021-10-24 17:12:39 +02:00 committed by GitHub
parent e6d5059cbb
commit df40e94673
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -76,8 +76,10 @@ bool oops_detail_namespace_is_visible;
namespace fmt { namespace fmt {
bool namespace_detail_invisible() { bool namespace_detail_invisible() {
#if defined(FMT_HIDE_MODULE_BUGS) && defined(_MSC_FULL_VER) && \ #if defined(FMT_HIDE_MODULE_BUGS) && defined(_MSC_FULL_VER) && \
_MSC_FULL_VER <= 192930129 ((_MSC_VER == 1929 && _MSC_FULL_VER <= 192930136) || \
// bug in msvc up to 16.11-pre1: (_MSC_VER == 1930 && _MSC_FULL_VER <= 193030704))
// bug in msvc up to 16.11.5 / 17.0-pre5:
// the namespace is visible even when it is neither // the namespace is visible even when it is neither
// implicitly nor explicitly exported // implicitly nor explicitly exported
return true; return true;
@ -97,8 +99,8 @@ TEST(module_test, detail_namespace) {
// macros must not be imported from a *named* module [cpp.import]/5.1 // macros must not be imported from a *named* module [cpp.import]/5.1
TEST(module_test, macros) { TEST(module_test, macros) {
#if defined(FMT_HIDE_MODULE_BUGS) && defined(_MSC_FULL_VER) && \ #if defined(FMT_HIDE_MODULE_BUGS) && defined(_MSC_FULL_VER) && \
_MSC_FULL_VER <= 192930129 _MSC_FULL_VER <= 192930130
// bug in msvc up to 16.11-pre1: // bug in msvc up to 16.11-pre2:
// include-guard macros leak from BMI // include-guard macros leak from BMI
// and even worse: they cannot be #undef-ined // and even worse: they cannot be #undef-ined
macro_leaked = false; macro_leaked = false;
@ -456,8 +458,7 @@ TEST(module_test, time_duration) {
} }
TEST(module_test, weekday) { TEST(module_test, weekday) {
EXPECT_EQ("Monday", EXPECT_EQ("Mon", fmt::format(std::locale::classic(), "{}", fmt::weekday(1)));
std::format(std::locale::classic(), "{:%A}", fmt::weekday(1)));
} }
TEST(module_test, to_string_view) { TEST(module_test, to_string_view) {