From ddd087d8d1670aa6a9284ae2a4fefdedcddee07a Mon Sep 17 00:00:00 2001
From: Victor Zverovich <victor.zverovich@gmail.com>
Date: Wed, 13 Aug 2014 06:42:15 -0700
Subject: [PATCH] Test more length specifiers.

---
 test/printf-test.cc | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/test/printf-test.cc b/test/printf-test.cc
index fc4b6234..b5cc96ec 100644
--- a/test/printf-test.cc
+++ b/test/printf-test.cc
@@ -333,8 +333,10 @@ void TestLength(const char *length_spec) {
   TestLength<T>(length_spec, -42);
   TestLength<T>(length_spec, min);
   TestLength<T>(length_spec, max);
-  TestLength<T>(length_spec, fmt::LongLong(min) - 1);
-  TestLength<T>(length_spec, fmt::LongLong(max) + 1);
+  if (min > std::numeric_limits<fmt::LongLong>::min())
+    TestLength<T>(length_spec, fmt::LongLong(min) - 1);
+  if (max < std::numeric_limits<fmt::LongLong>::max())
+    TestLength<T>(length_spec, fmt::LongLong(max) + 1);
   TestLength<T>(length_spec, std::numeric_limits<short>::min());
   TestLength<T>(length_spec, std::numeric_limits<unsigned short>::max());
   TestLength<T>(length_spec, std::numeric_limits<int>::min());
@@ -355,9 +357,10 @@ TEST(PrintfTest, Length) {
   TestLength<unsigned short>("h");
   TestLength<long>("l");
   TestLength<unsigned long>("l");
-  // TODO: more tests
-  //EXPECT_EQ("-1", sprintf_int<unsigned char>("%hhd", UCHAR_MAX));
-  //EXPECT_EQ("255", sprintf_int<unsigned char>("%hhu", UCHAR_MAX));
+  TestLength<intmax_t>("j");
+  TestLength<std::size_t>("z");
+  TestLength<std::ptrdiff_t>("t");
+  // TODO: test 'L' & 'll'
 }
 
 // TODO: test type specifier