From dc69cc45d2334106e6cd6fc4bbd601b6a75ee4e9 Mon Sep 17 00:00:00 2001 From: Victor Zverovich Date: Fri, 21 Sep 2018 07:21:49 -0700 Subject: [PATCH] Clean tests --- test/core-test.cc | 5 ++--- test/folly/Range.h | 17 ----------------- 2 files changed, 2 insertions(+), 20 deletions(-) delete mode 100644 test/folly/Range.h diff --git a/test/core-test.cc b/test/core-test.cc index 66475b03..fed78c3b 100644 --- a/test/core-test.cc +++ b/test/core-test.cc @@ -397,8 +397,7 @@ TEST(ArgTest, CustomArg) { } TEST(ArgTest, VisitInvalidArg) { - typedef mock_visitor Visitor; - testing::StrictMock visitor; + testing::StrictMock< mock_visitor > visitor; EXPECT_CALL(visitor, visit(_)); fmt::basic_format_arg arg; visit(visitor, arg); @@ -446,7 +445,7 @@ TEST(CoreTest, ConvertToInt) { EXPECT_TRUE((fmt::convert_to_int::value)); } -enum enum_with_underlying_type : char {TestValue}; +enum enum_with_underlying_type : char {}; TEST(CoreTest, IsEnumConvertibleToInt) { EXPECT_TRUE((fmt::convert_to_int::value)); diff --git a/test/folly/Range.h b/test/folly/Range.h deleted file mode 100644 index f794019f..00000000 --- a/test/folly/Range.h +++ /dev/null @@ -1,17 +0,0 @@ -// A folly::StringPiece stub. - -#include - -namespace folly { -class StringPiece { - public: - explicit StringPiece(const char *s) : data_(s), size_(std::strlen(s)) {} - - const char* data() const { return "foo"; } - size_t size() const { return 3; } - - private: - const char *data_; - size_t size_; -}; -}