diff --git a/include/fmt/format.h b/include/fmt/format.h index 336d2c67..8e93a565 100644 --- a/include/fmt/format.h +++ b/include/fmt/format.h @@ -758,9 +758,9 @@ using uint32_or_64_or_128_t = // Smallest of uint32_t, uint64_t, uint128_t that is large enough to // represent all values of T. template -using uint32_or_64_or_128_t = conditional_t< - num_bits() <= 32, uint32_t, - conditional_t() <= 64, uint64_t, uint128_t>>; +using uint32_or_64_or_128_t = + conditional_t() <= 32, uint32_t, + conditional_t() <= 64, uint64_t, uint128_t>>; #endif // Static data is placed in this class template for the header-only config. @@ -1607,7 +1607,8 @@ template struct int_writer { make_checked(p, s.size())); } if (prefix_size != 0) p[-1] = static_cast('-'); - write(out, basic_string_view(buffer.data(), buffer.size()), specs); + out = write(out, basic_string_view(buffer.data(), buffer.size()), + specs); } void on_chr() { *out++ = static_cast(abs_value); } diff --git a/test/locale-test.cc b/test/locale-test.cc index 15a40d99..b2cb8a63 100644 --- a/test/locale-test.cc +++ b/test/locale-test.cc @@ -89,4 +89,16 @@ TEST(LocaleTest, WFormat) { fmt::format(small_grouping_loc, L"{:L}", max_value())); } +TEST(LocaleTest, DoubleFormatter) { + auto loc = std::locale(std::locale(), new special_grouping()); + auto f = fmt::formatter(); + auto parse_ctx = fmt::format_parse_context("L"); + f.parse(parse_ctx); + char buf[10] = {}; + fmt::basic_format_context format_ctx( + buf, {}, fmt::detail::locale_ref(loc)); + *f.format(12345, format_ctx) = 0; + EXPECT_STREQ("12,345", buf); +} + #endif // FMT_STATIC_THOUSANDS_SEPARATOR