From 1c8bb54703bad237ab7f64464720a19e4f579994 Mon Sep 17 00:00:00 2001 From: medithe <40990424+medithe@users.noreply.github.com> Date: Thu, 13 Aug 2020 20:56:03 +0200 Subject: [PATCH] small changes to reduce clang-9 warnings (#1808) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * include/fmt/format.h: int_writer: removed unnecessary iterator type re-declaration (prevents shadow-waringing in clang) * include/fmt/format.h: int_writer: correctly cast signed integer to unsigned to prevent 'implicit conversion changes signedness'-warnings in clang. Co-authored-by: Martin Wührer --- include/fmt/format.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/fmt/format.h b/include/fmt/format.h index efe090d0..dc88a984 100644 --- a/include/fmt/format.h +++ b/include/fmt/format.h @@ -1610,7 +1610,8 @@ template struct int_writer { format_decimal(digits, abs_value, num_digits); basic_memory_buffer buffer; size += prefix_size; - buffer.resize(to_unsigned(size)); + const auto usize = to_unsigned(size); + buffer.resize(usize); basic_string_view s(&sep, sep_size); // Index of a decimal digit with the least significant digit having index 0. int digit_index = 0; @@ -1630,9 +1631,8 @@ template struct int_writer { make_checked(p, s.size())); } if (prefix_size != 0) p[-1] = static_cast('-'); - using iterator = remove_reference_t; auto data = buffer.data(); - out = write_padded(out, specs, size, size, [=](iterator it) { + out = write_padded(out, specs, usize, usize, [=](iterator it) { return copy_str(data, data + size, it); }); }