mirror of
https://github.com/dolphin-emu/dolphin.git
synced 2025-04-23 17:42:34 +00:00
71ce8bb6f0
In theory, our config system supports calling Set from any thread. But because we have config callbacks that call RunAsCPUThread, it's a lot more restricted in practice. Calling Set from any thread other than the host thread or the CPU thread is formally thread unsafe, and calling Set on the host thread while the CPU thread is showing a panic alert causes a deadlock. This is especially a problem because 04072f0 made the "Ignore for this session" button in panic alerts call Set. Because so many of our config callbacks want their code to run on the CPU thread, I thought it would make sense to have a centralized way to move execution to the CPU thread for config callbacks. To solve the deadlock problem, this new way is non-blocking. This means that threads other than the CPU thread might continue executing before the CPU thread is informed of the new config, but I don't think there's any problem with that. Intends to fix https://bugs.dolphin-emu.org/issues/13108.
23 lines
754 B
C++
23 lines
754 B
C++
// Copyright 2023 Dolphin Emulator Project
|
|
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#pragma once
|
|
|
|
#include "Common/Config/Config.h"
|
|
|
|
// This file lets you register callbacks like in Common/Config/Config.h, with the difference that
|
|
// callbacks registered here are guaranteed to run on the CPU thread. Callbacks registered here may
|
|
// run with a slight delay compared to regular config callbacks.
|
|
|
|
namespace CPUThreadConfigCallback
|
|
{
|
|
// returns an ID that can be passed to RemoveConfigChangedCallback()
|
|
size_t AddConfigChangedCallback(Config::ConfigChangedCallback func);
|
|
|
|
void RemoveConfigChangedCallback(size_t callback_id);
|
|
|
|
// Should be called regularly from the CPU thread
|
|
void CheckForConfigChanges();
|
|
|
|
}; // namespace CPUThreadConfigCallback
|