mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-06 12:40:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

VideoCommon: Remove dstalpha from BlendingState

Browse Source 
It's not supported by any PC graphics API, and therefore completely unused
This commit is contained in:
TellowKrinkle 2022-06-13 18:24:57 -05:00
parent 991024173e
commit fb5648541c
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Source/Core/VideoCommon/RenderState.cpp
View File

@ -120,12 +120,12 @@ void BlendingState::Generate(const BPMemory& bp)
// Start with everything disabled. // Start with everything disabled.
hex = 0; hex = 0;
bool target_has_alpha = bp.zcontrol.pixel_format == PixelFormat::RGBA6_Z24; const bool target_has_alpha = bp.zcontrol.pixel_format == PixelFormat::RGBA6_Z24;
bool alpha_test_may_succeed = bp.alpha_test.TestResult() != AlphaTestResult::Fail; const bool alpha_test_may_succeed = bp.alpha_test.TestResult() != AlphaTestResult::Fail;
colorupdate = bp.blendmode.colorupdate && alpha_test_may_succeed; colorupdate = bp.blendmode.colorupdate && alpha_test_may_succeed;
alphaupdate = bp.blendmode.alphaupdate && target_has_alpha && alpha_test_may_succeed; alphaupdate = bp.blendmode.alphaupdate && target_has_alpha && alpha_test_may_succeed;
dstalpha = bp.dstalpha.enable && alphaupdate; const bool dstalpha = bp.dstalpha.enable && alphaupdate;
usedualsrc = true; usedualsrc = true;
// The subtract bit has the highest priority // The subtract bit has the highest priority

1
Source/Core/VideoCommon/RenderState.h
View File

@ -130,7 +130,6 @@ union BlendingState
BitField<0, 1, u32> blendenable; BitField<0, 1, u32> blendenable;
BitField<1, 1, u32> logicopenable; BitField<1, 1, u32> logicopenable;
BitField<2, 1, u32> dstalpha;
BitField<3, 1, u32> colorupdate; BitField<3, 1, u32> colorupdate;
BitField<4, 1, u32> alphaupdate; BitField<4, 1, u32> alphaupdate;
BitField<5, 1, u32> subtract; BitField<5, 1, u32> subtract;