mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-10 12:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4469 from sepalani/fix_xfb_debug

Browse Source 
[HLE] Fixes XFB issues in Debug Mode
This commit is contained in:
Anthony 2017-04-29 12:48:53 -07:00 committed by GitHub
commit ecf5f7d5f4
6 changed files with 29 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
Source/Core/Core/HLE/HLE.cpp
View File

@ -55,17 +55,17 @@ static const SPatch OSPatches[] = {
{"OSPanic", HLE_OS::HLE_OSPanic, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"OSPanic", HLE_OS::HLE_OSPanic, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG},
// This needs to be put before vprintf (because vprintf is called indirectly by this) // This needs to be put before vprintf (because vprintf is called indirectly by this)
{"JUTWarningConsole_f", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"JUTWarningConsole_f", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"OSReport", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"OSReport", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"DEBUGPrint", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"DEBUGPrint", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"WUD_DEBUGPrint", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"WUD_DEBUGPrint", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"vprintf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"vprintf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"printf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"printf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"nlPrintf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, {"nlPrintf", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG},
{"puts", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, // gcc-optimized printf? {"puts", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG}, // gcc-optimized printf?
{"___blank", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, // used for early init things (normally) {"___blank", HLE_OS::HLE_GeneralDebugPrint, HLE_HOOK_START, HLE_TYPE_DEBUG}, // used for early init things (normally)
{"__write_console", HLE_OS::HLE_write_console, HLE_HOOK_REPLACE, HLE_TYPE_DEBUG}, // used by sysmenu (+more?) {"__write_console", HLE_OS::HLE_write_console, HLE_HOOK_START, HLE_TYPE_DEBUG}, // used by sysmenu (+more?)
{"GeckoCodehandler", HLE_Misc::GeckoCodeHandlerICacheFlush, HLE_HOOK_START, HLE_TYPE_FIXED}, {"GeckoCodehandler", HLE_Misc::GeckoCodeHandlerICacheFlush, HLE_HOOK_START, HLE_TYPE_FIXED},
{"GeckoHandlerReturnTrampoline", HLE_Misc::GeckoReturnTrampoline, HLE_HOOK_REPLACE, HLE_TYPE_FIXED}, {"GeckoHandlerReturnTrampoline", HLE_Misc::GeckoReturnTrampoline, HLE_HOOK_REPLACE, HLE_TYPE_FIXED},
@ -183,12 +183,21 @@ void Execute(u32 _CurrentPC, u32 _Instruction)
// OSPatches[pos].m_szPatchName); // OSPatches[pos].m_szPatchName);
} }
u32 GetFunctionIndex(u32 addr) u32 GetFunctionIndex(u32 address)
{ {
auto iter = s_original_instructions.find(addr); auto iter = s_original_instructions.find(address);
return (iter != s_original_instructions.end()) ? iter->second : 0; return (iter != s_original_instructions.end()) ? iter->second : 0;
} }
u32 GetFirstFunctionIndex(u32 address)
{
u32 index = GetFunctionIndex(address);
auto first = std::find_if(
s_original_instructions.begin(), s_original_instructions.end(),
[=](const auto& entry) { return entry.second == index && entry.first < address; });
return first == std::end(s_original_instructions) ? index : 0;
}
int GetFunctionTypeByIndex(u32 index) int GetFunctionTypeByIndex(u32 index)
{ {
return OSPatches[index].type; return OSPatches[index].type;

5
Source/Core/Core/HLE/HLE.h
View File

@ -34,7 +34,10 @@ u32 UnPatch(const std::string& patchName);
bool UnPatch(u32 addr, const std::string& name = {}); bool UnPatch(u32 addr, const std::string& name = {});
void Execute(u32 _CurrentPC, u32 _Instruction); void Execute(u32 _CurrentPC, u32 _Instruction);
u32 GetFunctionIndex(u32 em_address); // Returns the HLE function index if the address is located in the function
u32 GetFunctionIndex(u32 address);
// Returns the HLE function index if the address matches the function start
u32 GetFirstFunctionIndex(u32 address);
int GetFunctionTypeByIndex(u32 index); int GetFunctionTypeByIndex(u32 index);
int GetFunctionFlagsByIndex(u32 index); int GetFunctionFlagsByIndex(u32 index);

2
Source/Core/Core/PowerPC/CachedInterpreter/CachedInterpreter.cpp
View File

@ -205,7 +205,7 @@ void CachedInterpreter::Jit(u32 address)
{ {
js.downcountAmount += ops[i].opinfo->numCycles; js.downcountAmount += ops[i].opinfo->numCycles;
u32 function = HLE::GetFunctionIndex(ops[i].address); u32 function = HLE::GetFirstFunctionIndex(ops[i].address);
if (function != 0) if (function != 0)
{ {
int type = HLE::GetFunctionTypeByIndex(function); int type = HLE::GetFunctionTypeByIndex(function);

2
Source/Core/Core/PowerPC/Interpreter/Interpreter.cpp
View File

@ -100,7 +100,7 @@ static void Trace(UGeckoInstruction& inst)
int Interpreter::SingleStepInner() int Interpreter::SingleStepInner()
{ {
static UGeckoInstruction instCode; static UGeckoInstruction instCode;
u32 function = HLE::GetFunctionIndex(PC); u32 function = HLE::GetFirstFunctionIndex(PC);
if (function != 0) if (function != 0)
{ {
int type = HLE::GetFunctionTypeByIndex(function); int type = HLE::GetFunctionTypeByIndex(function);

2
Source/Core/Core/PowerPC/Jit64/Jit.cpp
View File

@ -797,7 +797,7 @@ const u8* Jit64::DoJit(u32 em_address, PPCAnalyst::CodeBuffer* code_buf, JitBloc
SetJumpTarget(noExtIntEnable); SetJumpTarget(noExtIntEnable);
} }
u32 function = HLE::GetFunctionIndex(ops[i].address); u32 function = HLE::GetFirstFunctionIndex(ops[i].address);
if (function != 0) if (function != 0)
{ {
int type = HLE::GetFunctionTypeByIndex(function); int type = HLE::GetFunctionTypeByIndex(function);

2
Source/Core/Core/PowerPC/Jit64IL/JitIL.cpp
View File

@ -604,7 +604,7 @@ const u8* JitIL::DoJit(u32 em_address, PPCAnalyst::CodeBuffer* code_buf, JitBloc
if (i == (code_block.m_num_instructions - 1)) if (i == (code_block.m_num_instructions - 1))
js.isLastInstruction = true; js.isLastInstruction = true;
u32 function = HLE::GetFunctionIndex(ops[i].address); u32 function = HLE::GetFirstFunctionIndex(ops[i].address);
if (function != 0) if (function != 0)
{ {
int type = HLE::GetFunctionTypeByIndex(function); int type = HLE::GetFunctionTypeByIndex(function);