From e06a62d9d19f379ef8f743251f4722db93aca77e Mon Sep 17 00:00:00 2001 From: dreamsyntax Date: Wed, 15 May 2019 22:13:57 -0700 Subject: [PATCH] Qt: Fix CodeWidget navigation Changed itemSelectionChanged and itemClicked signal to itemPressed in CodeWidget. Holding mouse down and moving will only travel up/down the stack one time. This fixes the common occurrence of unintentionally traveling deeper down the stack or higher up the callstack than intended. --- Source/Core/DolphinQt/Debugger/CodeWidget.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp index bdd8b5fa43..443da54042 100644 --- a/Source/Core/DolphinQt/Debugger/CodeWidget.cpp +++ b/Source/Core/DolphinQt/Debugger/CodeWidget.cpp @@ -155,12 +155,11 @@ void CodeWidget::ConnectWidgets() connect(m_search_address, &QLineEdit::textChanged, this, &CodeWidget::OnSearchAddress); connect(m_search_symbols, &QLineEdit::textChanged, this, &CodeWidget::OnSearchSymbols); - connect(m_symbols_list, &QListWidget::itemClicked, this, &CodeWidget::OnSelectSymbol); - connect(m_callstack_list, &QListWidget::itemSelectionChanged, this, - &CodeWidget::OnSelectCallstack); - connect(m_function_calls_list, &QListWidget::itemSelectionChanged, this, + connect(m_symbols_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectSymbol); + connect(m_callstack_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectCallstack); + connect(m_function_calls_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectFunctionCalls); - connect(m_function_callers_list, &QListWidget::itemSelectionChanged, this, + connect(m_function_callers_list, &QListWidget::itemPressed, this, &CodeWidget::OnSelectFunctionCallers); connect(m_code_view, &CodeViewWidget::SymbolsChanged, this, &CodeWidget::UpdateSymbols);