VideoCommon: Drop SetDitherMode()

It was a no-op on all backends apart from GL anyhow.

Source/Core/VideoBackends/D3D/Render.cpp

@@ -1085,11 +1085,6 @@ void Renderer::SetLogicOpMode()
   }
 }
 
-void Renderer::SetDitherMode()
-{
-  // TODO: Set dither mode to bpmem.blendmode.dither
-}
-
 void Renderer::SetSamplerState(int stage, int texindex, bool custom_tex)
 {
   const FourTexUnits& tex = bpmem.tex[texindex];

Source/Core/VideoBackends/D3D/Render.h

@@ -25,7 +25,6 @@ public:
   void SetGenerationMode() override;
   void SetDepthMode() override;
   void SetLogicOpMode() override;
-  void SetDitherMode() override;
   void SetSamplerState(int stage, int texindex, bool custom_tex) override;
   void SetInterlacingMode() override;
   void SetViewport() override;

Source/Core/VideoBackends/D3D12/Render.cpp

@@ -1108,11 +1108,6 @@ void Renderer::SetLogicOpMode()
   D3D::command_list_mgr->SetCommandListDirtyState(COMMAND_LIST_STATE_PSO, true);
 }
 
-void Renderer::SetDitherMode()
-{
-  // EXISTINGD3D11TODO: Set dither mode to bpmem.blendmode.dither
-}
-
 void Renderer::SetSamplerState(int stage, int tex_index, bool custom_tex)
 {
   const FourTexUnits& tex = bpmem.tex[tex_index];

Source/Core/VideoBackends/D3D12/Render.h

@@ -26,7 +26,6 @@ public:
   void SetGenerationMode() override;
   void SetDepthMode() override;
   void SetLogicOpMode() override;
-  void SetDitherMode() override;
   void SetSamplerState(int stage, int tex_index, bool custom_tex) override;
   void SetInterlacingMode() override;
   void SetViewport() override;

Source/Core/VideoBackends/Vulkan/Renderer.cpp

@@ -1383,10 +1383,6 @@ void Renderer::ResetSamplerStates()
   g_object_cache->ClearSamplerCache();
 }
 
-void Renderer::SetDitherMode()
-{
-}
-
 void Renderer::SetInterlacingMode()
 {
 }

Source/Core/VideoBackends/Vulkan/Renderer.h

@@ -60,7 +60,6 @@ public:
   void SetScissorRect(const EFBRectangle& rc) override;
   void SetGenerationMode() override;
   void SetDepthMode() override;
-  void SetDitherMode() override;
   void SetSamplerState(int stage, int texindex, bool custom_tex) override;
   void SetInterlacingMode() override;
   void SetViewport() override;

Source/Core/VideoCommon/BPFunctions.cpp

@@ -74,10 +74,7 @@ void SetBlendMode()
 {
   g_renderer->SetBlendMode(false);
 }
-void SetDitherMode()
+
-{
-  g_renderer->SetDitherMode();
-}
 void SetLogicOpMode()
 {
   g_renderer->SetLogicOpMode();

Source/Core/VideoCommon/BPFunctions.h

@@ -19,7 +19,6 @@ void SetGenerationMode();
 void SetScissor();
 void SetDepthMode();
 void SetBlendMode();
-void SetDitherMode();
 void SetLogicOpMode();
 void SetColorMask();
 void ClearScreen(const EFBRectangle& rc);

Source/Core/VideoCommon/BPStructs.cpp

@@ -152,10 +152,6 @@ static void BPWritten(const BPCmd& bp)
       if (bp.changes & 0xF002)  // logicopenable | logicmode
         SetLogicOpMode();
 
-      // Set Dithering Mode
-      if (bp.changes & 4)  // dither
-        SetDitherMode();
-
       // Set Color Mask
       if (bp.changes & 0x18)  // colorupdate | alphaupdate
         SetColorMask();
@@ -1383,7 +1379,6 @@ void BPReload()
   SetScissor();
   SetDepthMode();
   SetLogicOpMode();
-  SetDitherMode();
   SetBlendMode();
   SetColorMask();
   OnPixelFormatChange();

Source/Core/VideoCommon/RenderBase.h

@@ -69,7 +69,6 @@ public:
   virtual void SetGenerationMode() {}
   virtual void SetDepthMode() {}
   virtual void SetLogicOpMode() {}
-  virtual void SetDitherMode() {}
   virtual void SetSamplerState(int stage, int texindex, bool custom_tex) {}
   virtual void SetInterlacingMode() {}
   virtual void SetViewport() {}