mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-31 00:32:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add range checking to CopyTo/FromEmu so it won't segfault.

Browse Source
This commit is contained in:
Scott Mansell 2014-10-29 01:16:18 +13:00
parent 64b09582c6
commit d77f361c01
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Source/Core/Core/HW/Memmap.cpp
View File

@ -219,13 +219,30 @@ u32 Read_Instruction(const u32 em_address)
return inst.hex; return inst.hex;
} }
static inline bool ValidCopyRange(u32 address, size_t size)
{
return (GetPointer(address) != nullptr &&
GetPointer(address + u32(size)) != nullptr &&
size < EXRAM_SIZE); // Make sure we don't have a range spanning seperate 2 banks
}
void CopyFromEmu(void* data, u32 address, size_t size) void CopyFromEmu(void* data, u32 address, size_t size)
{ {
if (!ValidCopyRange(address, size))
{
PanicAlert("Invalid range in CopyFromEmu. %lx bytes from 0x%08x", size, address);
return;
}
memcpy(data, GetPointer(address), size); memcpy(data, GetPointer(address), size);
} }
void CopyToEmu(u32 address, const void* data, size_t size) void CopyToEmu(u32 address, const void* data, size_t size)
{ {
if (!ValidCopyRange(address, size))
{
PanicAlert("Invalid range in CopyToEmu. %lx bytes to 0x%08x", size, address);
return;
}
memcpy(GetPointer(address), data, size); memcpy(GetPointer(address), data, size);
} }