From d40022d6d07dfd93569c8d993b92b901fbde115b Mon Sep 17 00:00:00 2001
From: Lioncash <mathew1800@gmail.com>
Date: Mon, 27 Aug 2018 13:01:04 -0400
Subject: [PATCH] JitInterface: Move explanatory comment of ClearSafe() to the
function's prototype
Puts the comment in the header where it's more likely to be seen
initially. We can also remove the TODO, given doing nothing or returning
an error is what is generally done for the JIT interface if the JIT
instance isn't valid.
---
Source/Core/Core/PowerPC/JitInterface.cpp | 4 ----
Source/Core/Core/PowerPC/JitInterface.h | 3 +++
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/Source/Core/Core/PowerPC/JitInterface.cpp b/Source/Core/Core/PowerPC/JitInterface.cpp
index 07db190f29..47fb1634f0 100644
--- a/Source/Core/Core/PowerPC/JitInterface.cpp
+++ b/Source/Core/Core/PowerPC/JitInterface.cpp
@@ -211,10 +211,6 @@ void ClearCache()
}
void ClearSafe()
{
- // This clear is "safe" in the sense that it's okay to run from
- // inside a JIT'ed block: it clears the instruction cache, but not
- // the JIT'ed code.
- // TODO: There's probably a better way to handle this situation.
if (g_jit)
g_jit->GetBlockCache()->Clear();
}
diff --git a/Source/Core/Core/PowerPC/JitInterface.h b/Source/Core/Core/PowerPC/JitInterface.h
index 6fb88fe1d1..1420dd3c09 100644
--- a/Source/Core/Core/PowerPC/JitInterface.h
+++ b/Source/Core/Core/PowerPC/JitInterface.h
@@ -55,6 +55,9 @@ bool HandleStackFault();
// Clearing CodeCache
void ClearCache();
+// This clear is "safe" in the sense that it's okay to run from
+// inside a JIT'ed block: it clears the instruction cache, but not
+// the JIT'ed code.
void ClearSafe();
// If "forced" is true, a recompile is being requested on code that hasn't been modified.