mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-26 21:35:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Some commenting and added some unknown cases to BPStructs, see: http://code.google.com/p/dolphin-emu/issues/detail?id=360#c90

Browse Source 
git-svn-id: https://dolphin-emu.googlecode.com/svn/trunk@3530 8ced0084-cf51-0410-be5f-012b33b47a6e
This commit is contained in:
omegadox 2009-06-22 01:46:58 +00:00
parent cbd4f8937b
commit cfe3f77ccf
2 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/VideoCommon/Src/BPMemory.h
View File

@ -64,6 +64,10 @@
#define BPMEM_CLEARBBOX2 0x56 #define BPMEM_CLEARBBOX2 0x56
#define BPMEM_UNKNOWN 0x58 #define BPMEM_UNKNOWN 0x58
#define BPMEM_SCISSOROFFSET 0x59 #define BPMEM_SCISSOROFFSET 0x59
#define BPMEM_UNKNOWN1 0x60
#define BPMEM_UNKNOWN2 0x61
#define BPMEM_UNKNOWN3 0x62
#define BPMEM_UNKNOWN4 0x63
#define BPMEM_LOADTLUT0 0x64 #define BPMEM_LOADTLUT0 0x64
#define BPMEM_LOADTLUT1 0x65 #define BPMEM_LOADTLUT1 0x65
#define BPMEM_TEXINVALIDATE 0x66 #define BPMEM_TEXINVALIDATE 0x66

27
Source/Core/VideoCommon/Src/BPStructs.cpp
View File

@ -48,13 +48,13 @@ void BPInit()
// ---------------------------------------------------------------------------------------------------------- // ----------------------------------------------------------------------------------------------------------
void BPWritten(const Bypass& bp) void BPWritten(const Bypass& bp)
{ {
// -------------------------------------------------------------------------------------------------------- // --------------------------------------------------------------------------------------------------------
// First the pipeline is flushed then update the bpmem with the new value. // First the pipeline is flushed then update the bpmem with the new value.
// Some of the BP cases have to call certain functions while others just update the bpmem. // Some of the BP cases have to call certain functions while others just update the bpmem.
// some bp cases check the changes variable, because they might not have to be updated all the time // some bp cases check the changes variable, because they might not have to be updated all the time
// NOTE: it seems not all bp cases like checking changes, so calling if (bp.changes == 0 ? false : true) // NOTE: it seems not all bp cases like checking changes, so calling if (bp.changes == 0 ? false : true)
// had to be ditched and the games seem to work fine with out it. // had to be ditched and the games seem to work fine with out it.
// NOTE2: Yet Another Gamecube Documentation calls them Bypass Registers
// -------------------------------------------------------------------------------------------------------- // --------------------------------------------------------------------------------------------------------
// Debugging only, this lets you skip a bp update // Debugging only, this lets you skip a bp update
@ -298,12 +298,17 @@ void BPWritten(const Bypass& bp)
#endif #endif
break; break;
} }
case BPMEM_DISPLAYCOPYFILER: // Display Filtering Control, ignore this // ----------------------------------
// Display Copy Filtering Control
// Fields: Destination, Frame2Field, Gamma, Source
// TODO: We might have to implement the gamma one, some games might need this, if they are too dark to see.
// ----------------------------------
case BPMEM_DISPLAYCOPYFILER:
case BPMEM_DISPLAYCOPYFILER+1: case BPMEM_DISPLAYCOPYFILER+1:
case BPMEM_DISPLAYCOPYFILER+2: case BPMEM_DISPLAYCOPYFILER+2:
case BPMEM_DISPLAYCOPYFILER+3: case BPMEM_DISPLAYCOPYFILER+3:
case BPMEM_COPYFILTER0: case BPMEM_COPYFILTER0: //GXSetCopyFilter
case BPMEM_COPYFILTER1: case BPMEM_COPYFILTER1:
break; break;
case BPMEM_FIELDMASK: // Interlacing Control case BPMEM_FIELDMASK: // Interlacing Control
case BPMEM_FIELDMODE: case BPMEM_FIELDMODE:
@ -372,6 +377,13 @@ void BPWritten(const Bypass& bp)
PanicAlert("Unknown is not 0xF! val = 0x%08x", bp.newvalue); PanicAlert("Unknown is not 0xF! val = 0x%08x", bp.newvalue);
break; break;
// Cases added due to: http://code.google.com/p/dolphin-emu/issues/detail?id=360#c90
// Are these related to BBox?
case BPMEM_UNKNOWN1:
case BPMEM_UNKNOWN2:
case BPMEM_UNKNOWN3:
case BPMEM_UNKNOWN4:
break;
// ------------------------------------------------ // ------------------------------------------------
// On Default, we try to look for other things // On Default, we try to look for other things
// before we give up and say its an unknown opcode // before we give up and say its an unknown opcode
@ -392,7 +404,7 @@ void BPWritten(const Bypass& bp)
case BPMEM_TREF+7: case BPMEM_TREF+7:
break; break;
// ---------------------- // ----------------------
// Set a triangle's Wrap // Set wrap size
// ---------------------- // ----------------------
case BPMEM_SU_SSIZE: case BPMEM_SU_SSIZE:
case BPMEM_SU_TSIZE: case BPMEM_SU_TSIZE:
@ -571,7 +583,10 @@ void BPWritten(const Bypass& bp)
case BPMEM_TEV_ALPHA_ENV+30: case BPMEM_TEV_ALPHA_ENV+30:
case BPMEM_TEV_COLOR_ENV+32: // Texture Environment 16 case BPMEM_TEV_COLOR_ENV+32: // Texture Environment 16
case BPMEM_TEV_ALPHA_ENV+32: case BPMEM_TEV_ALPHA_ENV+32:
break; break;
default:
WARN_LOG(VIDEO, "Unknown Bypass opcode: address = 0x%08x value = 0x%08x", bp.address, bp.newvalue);
break;
} }
} }