From ae187818f56dad3b5b0fb476045d20207f2823e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Fri, 25 Dec 2020 01:15:31 +0100 Subject: [PATCH 1/2] PowerPC: Fix GDBStub build --- Source/Core/Core/PowerPC/GDBStub.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Core/Core/PowerPC/GDBStub.cpp b/Source/Core/Core/PowerPC/GDBStub.cpp index fe2476584c..d2b635aae7 100644 --- a/Source/Core/Core/PowerPC/GDBStub.cpp +++ b/Source/Core/Core/PowerPC/GDBStub.cpp @@ -240,7 +240,7 @@ static void gdb_read_command() cmd_len = 0; memset(cmd_bfr, 0, sizeof cmd_bfr); - const u8 c = gdb_read_byte(); + u8 c = gdb_read_byte(); if (c == '+') { // ignore ack From 0aadb9fd7bec2727face917276e1ab96f77c50c4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Lam?= Date: Fri, 25 Dec 2020 01:16:05 +0100 Subject: [PATCH 2/2] Build the gdbstub by default While the gdbstub is somewhat broken at the moment, building it by default should keep us from breaking the build (which has happened several times in the past: #2614, #5904, #8262). It isn't very intrusive and it does nothing unless it is enabled in the config file. --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 15c4126d64..eb5d2edfe3 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -50,7 +50,7 @@ option(ENCODE_FRAMEDUMPS "Encode framedumps in AVI format" ON) option(ENABLE_GPROF "Enable gprof profiling (must be using Debug build)" OFF) option(FASTLOG "Enable all logs" OFF) -option(GDBSTUB "Enable gdb stub for remote debugging." OFF) +option(GDBSTUB "Enable gdb stub for remote debugging." ON) option(OPROFILING "Enable profiling" OFF) # TODO: Add DSPSpy