mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-01 12:32:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Jit: Get rid of short-lived std::vectors

Browse Source 
Let's aim for making as few heap allocations as possible while jitting.
This commit is contained in:
JosJuice 2023-11-18 18:53:39 +01:00
parent b40a824f92
commit c3c0c7dc1c
4 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Source/Core/Core/PowerPC/Jit64/Jit_FloatingPoint.cpp
View File

@ -7,12 +7,12 @@
#include <cmath> #include <cmath>
#include <limits> #include <limits>
#include <optional> #include <optional>
#include <vector>
#include "Common/Assert.h" #include "Common/Assert.h"
#include "Common/CPUDetect.h" #include "Common/CPUDetect.h"
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#include "Common/Config/Config.h" #include "Common/Config/Config.h"
#include "Common/SmallVector.h"
#include "Common/x64Emitter.h" #include "Common/x64Emitter.h"
#include "Core/Config/SessionSettings.h" #include "Core/Config/SessionSettings.h"
#include "Core/ConfigManager.h" #include "Core/ConfigManager.h"
@ -119,7 +119,7 @@ void Jit64::HandleNaNs(UGeckoInstruction inst, X64Reg xmm, X64Reg clobber, std::
SetJumpTarget(handle_nan); SetJumpTarget(handle_nan);
// If any inputs are NaNs, pick the first NaN of them // If any inputs are NaNs, pick the first NaN of them
std::vector<FixupBranch> fixups; Common::SmallVector<FixupBranch, 3> fixups;
const auto check_input = [&](const OpArg& Rx) { const auto check_input = [&](const OpArg& Rx) {
MOVDDUP(xmm, Rx); MOVDDUP(xmm, Rx);
UCOMISD(xmm, R(xmm)); UCOMISD(xmm, R(xmm));

4
Source/Core/Core/PowerPC/Jit64/Jit_Integer.cpp
View File

@ -6,13 +6,13 @@
#include <array> #include <array>
#include <bit> #include <bit>
#include <limits> #include <limits>
#include <vector>
#include "Common/Assert.h" #include "Common/Assert.h"
#include "Common/BitUtils.h" #include "Common/BitUtils.h"
#include "Common/CPUDetect.h" #include "Common/CPUDetect.h"
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#include "Common/MathUtil.h" #include "Common/MathUtil.h"
#include "Common/SmallVector.h"
#include "Common/x64Emitter.h" #include "Common/x64Emitter.h"
#include "Core/CoreTiming.h" #include "Core/CoreTiming.h"
@ -2723,7 +2723,7 @@ void Jit64::twX(UGeckoInstruction inst)
} }
constexpr std::array<CCFlags, 5> conditions{{CC_A, CC_B, CC_E, CC_G, CC_L}}; constexpr std::array<CCFlags, 5> conditions{{CC_A, CC_B, CC_E, CC_G, CC_L}};
std::vector<FixupBranch> fixups; Common::SmallVector<FixupBranch, conditions.size()> fixups;
for (size_t i = 0; i < conditions.size(); i++) for (size_t i = 0; i < conditions.size(); i++)
{ {

5
Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp
View File

@ -9,6 +9,7 @@
#include "Common/CPUDetect.h" #include "Common/CPUDetect.h"
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#include "Common/Config/Config.h" #include "Common/Config/Config.h"
#include "Common/SmallVector.h"
#include "Common/StringUtil.h" #include "Common/StringUtil.h"
#include "Core/Config/SessionSettings.h" #include "Core/Config/SessionSettings.h"
@ -189,7 +190,7 @@ void JitArm64::fp_arith(UGeckoInstruction inst)
break; break;
} }
std::vector<FixupBranch> nan_fixups; Common::SmallVector<FixupBranch, 4> nan_fixups;
if (m_accurate_nans) if (m_accurate_nans)
{ {
// Check if we need to handle NaNs // Check if we need to handle NaNs
@ -205,7 +206,7 @@ void JitArm64::fp_arith(UGeckoInstruction inst)
EmitQuietNaNBitConstant(quiet_bit_reg, inputs_are_singles && output_is_single, temp_gpr); EmitQuietNaNBitConstant(quiet_bit_reg, inputs_are_singles && output_is_single, temp_gpr);
std::vector<ARM64Reg> inputs; Common::SmallVector<ARM64Reg, 3> inputs;
inputs.push_back(VA); inputs.push_back(VA);
if (use_b && VA != VB) if (use_b && VA != VB)
inputs.push_back(VB); inputs.push_back(VB);

9
Source/Core/Core/PowerPC/JitArm64/JitArm64_SystemRegisters.cpp
View File

@ -3,10 +3,13 @@
#include "Core/PowerPC/JitArm64/Jit.h" #include "Core/PowerPC/JitArm64/Jit.h"
#include <array>
#include "Common/Arm64Emitter.h" #include "Common/Arm64Emitter.h"
#include "Common/Assert.h" #include "Common/Assert.h"
#include "Common/CommonTypes.h" #include "Common/CommonTypes.h"
#include "Common/MathUtil.h" #include "Common/MathUtil.h"
#include "Common/SmallVector.h"
#include "Core/Core.h" #include "Core/Core.h"
#include "Core/CoreTiming.h" #include "Core/CoreTiming.h"
@ -231,10 +234,10 @@ void JitArm64::twx(UGeckoInstruction inst)
CMP(gpr.R(a), gpr.R(inst.RB)); CMP(gpr.R(a), gpr.R(inst.RB));
} }
std::vector<FixupBranch> fixups; constexpr std::array<CCFlags, 5> conditions{{CC_LT, CC_GT, CC_EQ, CC_VC, CC_VS}};
CCFlags conditions[] = {CC_LT, CC_GT, CC_EQ, CC_VC, CC_VS}; Common::SmallVector<FixupBranch, conditions.size()> fixups;
for (int i = 0; i < 5; i++) for (int i = 0; i < conditions.size(); i++)
{ {
if (inst.TO & (1 << i)) if (inst.TO & (1 << i))
{ {