mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-02-07 06:40:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Interpreter: Get rid of static state within SingleStepInner()

Browse Source 
Given how the hooking operates, we may not execute an instruction.
Instead of making the state a static local to the function, just make it
part of the lifecycle of the Interpreter class.
This commit is contained in:
Lioncash 2018-03-25 21:23:15 -04:00
parent 5c83e18fbd
commit b0efcdc8ef
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Source/Core/Core/PowerPC/Interpreter/Interpreter.cpp
View File

@ -101,7 +101,6 @@ static void Trace(UGeckoInstruction& inst)
int Interpreter::SingleStepInner()
{
static UGeckoInstruction instCode;
u32 function = HLE::GetFirstFunctionIndex(PC);
if (function != 0)
{
@ -138,7 +137,7 @@ int Interpreter::SingleStepInner()
#endif
NPC = PC + sizeof(UGeckoInstruction);
instCode.hex = PowerPC::Read_Opcode(PC);
m_prev_inst.hex = PowerPC::Read_Opcode(PC);
// Uncomment to trace the interpreter
// if ((PC & 0xffffff)>=0x0ab54c && (PC & 0xffffff)<=0x0ab624)
@ -148,15 +147,15 @@ int Interpreter::SingleStepInner()
if (startTrace)
{
Trace(instCode);
Trace(m_prev_inst);
}
if (instCode.hex != 0)
if (m_prev_inst.hex != 0)
{
UReg_MSR& msr = (UReg_MSR&)MSR;
if (msr.FP) // If FPU is enabled, just execute
{
m_op_table[instCode.OPCD](instCode);
m_op_table[m_prev_inst.OPCD](m_prev_inst);
if (PowerPC::ppcState.Exceptions & EXCEPTION_DSI)
{
PowerPC::CheckExceptions();
@ -166,9 +165,9 @@ int Interpreter::SingleStepInner()
else
{
// check if we have to generate a FPU unavailable exception
if (!PPCTables::UsesFPU(instCode))
if (!PPCTables::UsesFPU(m_prev_inst))
{
m_op_table[instCode.OPCD](instCode);
m_op_table[m_prev_inst.OPCD](m_prev_inst);
if (PowerPC::ppcState.Exceptions & EXCEPTION_DSI)
{
PowerPC::CheckExceptions();
@ -193,7 +192,7 @@ int Interpreter::SingleStepInner()
last_pc = PC;
PC = NPC;
const GekkoOPInfo* opinfo = PPCTables::GetOpInfo(instCode);
const GekkoOPInfo* opinfo = PPCTables::GetOpInfo(m_prev_inst);
return opinfo->numCycles;
}

2
Source/Core/Core/PowerPC/Interpreter/Interpreter.h
View File

@ -304,6 +304,8 @@ private:
static void Helper_FloatCompareOrdered(UGeckoInstruction inst, double a, double b);
static void Helper_FloatCompareUnordered(UGeckoInstruction inst, double a, double b);
UGeckoInstruction m_prev_inst{};
static bool m_end_block;
// TODO: These should really be in the save state, although it's unlikely to matter much.