mirror/dolphin
1
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-04-01 10:20:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix comparison to invalidated vector iterator.

Browse Source 
GetFstEntryForPath may modify the children vector,
so do it before taking an iterator to the vector.
This commit is contained in:
Shawn Hoffman 2020-08-16 15:08:22 -07:00
parent 9d880c2db3
commit 9a5a705d01
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Source/Core/Core/IOS/FS/HostBackend/FS.cpp
View File

@ -515,9 +515,9 @@ ResultCode HostFileSystem::Rename(Uid uid, Gid gid, const std::string& old_path,
} }
// Finally, remove the child from the old parent and move it to the new parent. // Finally, remove the child from the old parent and move it to the new parent.
FstEntry* new_entry = GetFstEntryForPath(new_path);
const auto it = std::find_if(old_parent->children.begin(), old_parent->children.end(), const auto it = std::find_if(old_parent->children.begin(), old_parent->children.end(),
GetNamePredicate(split_old_path.file_name)); GetNamePredicate(split_old_path.file_name));
FstEntry* new_entry = GetFstEntryForPath(new_path);
if (it != old_parent->children.end()) if (it != old_parent->children.end())
{ {
*new_entry = *it; *new_entry = *it;