From 96525cbaaa8bf33b1cb3913492d6ca830d0183e8 Mon Sep 17 00:00:00 2001 From: Mike Harris Date: Mon, 25 Sep 2017 22:47:52 -0700 Subject: [PATCH] Remove unused FRAGMENT_TAG, and move the fragment's layout ID inline. FRAGMENT_ID wasn't actually the fragment's ID (that's misleading, and sounds like the tag). It's actually the layout resource ID. There's no point in making that a static constant. --- .../org/dolphinemu/dolphinemu/fragments/MenuFragment.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java index 236ed89228..2ab3e0ba6a 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/fragments/MenuFragment.java @@ -11,14 +11,11 @@ import android.widget.Button; import android.widget.LinearLayout; import android.widget.TextView; -import org.dolphinemu.dolphinemu.BuildConfig; import org.dolphinemu.dolphinemu.R; import org.dolphinemu.dolphinemu.activities.EmulationActivity; public final class MenuFragment extends Fragment implements View.OnClickListener { - public static final String FRAGMENT_TAG = BuildConfig.APPLICATION_ID + ".ingame_menu"; - public static final int FRAGMENT_ID = R.layout.fragment_ingame_menu; private TextView mTitleText; private static SparseIntArray buttonsActionsMap = new SparseIntArray(); static { @@ -35,7 +32,7 @@ public final class MenuFragment extends Fragment implements View.OnClickListener @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { - View rootView = inflater.inflate(FRAGMENT_ID, container, false); + View rootView = inflater.inflate(R.layout.fragment_ingame_menu, container, false); LinearLayout options = (LinearLayout) rootView.findViewById(R.id.layout_options); for (int childIndex = 0; childIndex < options.getChildCount(); childIndex++)